Add RequestVcErrorDetail enum #2836
Conversation
grumpygreenguy
added
the
C0-breaking
grumpygreenguy
requested review from
Kailai-Wang,
BillyWooo and
felixfaisal
and removed request for
Kailai-Wang
| @@ -102,10 +103,33 @@ pub struct RequestVCResult { | |||
| pub pre_id_graph_hash: H256, | |||
| } | |||
|
|
|||
| #[derive(Debug, Encode, Decode, Clone)] | |||
There was a problem hiding this comment.
I tried to incorporate the causing errors in the variants below, but ran into two issues:
- the respective (mostly 3rd party) error types don't implement the needed traits for
deriveto work here, and - clippy complained that the type was "too big" for an
Errvariant, hence theBoxin theAssertionBuildFailedvariant :sadpanda:
We discussed it earlier with @jonalvarezz (although this PR goes for a smaller change in the end) |
| #[derive(Debug, Encode, Decode, Clone)] | ||
| pub struct RequestVcResultOrError { | ||
| pub payload: Vec<u8>, | ||
| pub is_error: bool, | ||
| pub result: Result<Vec<u8>, RequestVcErrorDetail>, |
There was a problem hiding this comment.
nice! props for using the Result type
😄 i think it is – the value of the non-existent field is falsy, the condition doesn't meet |
💀 |
| @@ -14,6 +14,7 @@ | |||
| "ts-node": { | |||
| "esm": true, | |||
| "experimentalResolver": true, | |||
| "experimentalSpecifierResolution": "node" | |||
| "experimentalSpecifierResolution": "node", | |||
| "transpileOnly": true | |||
There was a problem hiding this comment.
Adding this to mitigate the error:NULL messages from mocha; see this issue /cc @jonalvarezz @0xverin
There was a problem hiding this comment.
tested locally via https://github.com/litentry/client-sdk/pull/35's update.
looking good. thanks, Ariel!
grumpygreenguy
deleted the
p-609-refactoring-struct-requestvcresultorerror
branch
Context
Partially implements P-609
Further refactoring of the API is needed, but deferred for now for timing constraints.
TODO