fix: P-927 refactor brc20 contract to configure tokens and networks #2900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n a unified place, remove redundant network loops in function queryBalance in TokenQueryLogic, move url config to dp client
higherordertech
force-pushed
the
refactor-BRC20
branch
from
ceae73b to
7cc4f10
Compare
0xverin
reviewed
Jul 16, 2024
| } | ||
| } | ||
| // Mark this network as queried | ||
| queriedNetworks[networks[i]] = true; |
There was a problem hiding this comment.
Should queriedNetworks mapping be removed here? If the network is bsc and ethereum, what I mean is when execute param is :
identities = [
{
identity_type: 4,
value: "0xf7764F15Fd4F695fAD8dDd3e84F5293E6866FEFE",
networks: [7, 8],
},
]
in this case, will it be queried twice here?
There was a problem hiding this comment.
As you said, same identity could has different networks, but we need sum the token balance from different network.
e.g.
- There has an evm identity A has 2 networks ethereum and bsc.
- We need generate TokenHoldingAmount VC for token TRX.
- The total balance of token TRX for identity A is: (TRX token balance in network ethereum) + (TRX token balance in network bsc).
0xverin
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in a unified place, remove redundant network loops in function queryBalance in TokenQueryLogic, move url config to dp client
Context
Labels
Please apply following PR-related labels when appropriate:
C0-breaking: if your change could break the existing client, e.g. API change, critical logic changeC1-noteworthy: if your change is non-breaking, but is still worth noticing for the client, e.g. reference code improvementHow (Optional)
Testing Evidences
Please attach any relevant evidences if applicable
I will have follow up PR to test the new bitcoin network type via cli tests.