Clear the score when the user fully unstakes #2992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
A small adjustment based on the new requirement.
When a user fully unstakes, his reward will become 0 according to the current logic, which is fine. However, his score shouldn't participate in the reward calculation, which is unfair to other users.
This PR fixes it in a brutal way - there's room to improve: both structural and algorithmetic way - but the time is limited, we can do the improvement later.
This PR simply clears the user's score for whoever has 0 staking when we calculate the rewards.
We can't simply remove the entry from
Scoresas the user might still have unclaimed reward.