Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply chain_ids from core_primitives #2999

Merged
merged 3 commits into from
Aug 18, 2024
Merged

Apply chain_ids from core_primitives #2999

merged 3 commits into from
Aug 18, 2024

Conversation

Kailai-Wang
Copy link
Collaborator

@Kailai-Wang Kailai-Wang commented Aug 18, 2024

Context

As topic
Do not merge it yet - we still wait for OK from IDH

@Kailai-Wang Kailai-Wang requested review from wangminqi and a team August 18, 2024 04:38
@Kailai-Wang Kailai-Wang self-assigned this Aug 18, 2024
@Kailai-Wang Kailai-Wang changed the title [DO NOT MERGE] Apply chain_ids from core_primitives Apply chain_ids from core_primitives Aug 18, 2024
Copy link
Member

@wangminqi wangminqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kailai-Wang Kailai-Wang enabled auto-merge (squash) August 18, 2024 06:52
@Kailai-Wang Kailai-Wang disabled auto-merge August 18, 2024 06:57
Copy link
Collaborator

@BillyWooo BillyWooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kailai-Wang Kailai-Wang merged commit 808902c into dev Aug 18, 2024
6 of 12 checks passed
@Kailai-Wang Kailai-Wang deleted the use-right-chain-id branch August 18, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants