Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CollabAI implementation #3030

Merged
merged 244 commits into from
Dec 4, 2024
Merged

CollabAI implementation #3030

merged 244 commits into from
Dec 4, 2024

Conversation

wangminqi
Copy link
Member

TBA

Copy link

linear bot commented Aug 29, 2024

@wangminqi wangminqi marked this pull request as draft August 29, 2024 05:47
@wangminqi wangminqi marked this pull request as ready for review September 29, 2024 07:31
@wangminqi wangminqi requested a review from Kailai-Wang December 1, 2024 14:48
pub const MinimumGuardianDeposit: Balance = 20 * DOLLARS;
// Declare the official AIUSDAssetId
pub const AIUSDAssetId: u128 = 1000;
pub OfficialGapPeriod: BlockNumber = prod_or_fast!(7 * DAYS, 10 * MINUTES, "ROCOCO_OFFICIALGAPPERIOD");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should change the name from ROCOCO to Paseo. There are two more below.
Besides, for non-prod, is 10*MINUTES the best choice? is there any concern to run non-prod env faster?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually the rococo name is still remained everywhere, not only brought in by the collabAI part code. I will raise another PR to replace the name.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the offficial gap period is the time between a pool proposal mature and an official investing pool begin accounting.
In reality, it should be equal to the approximate time of GPU data center setup.
In testing mode, any timeframe will work.

@Kailai-Wang Kailai-Wang requested review from a team and felixfaisal December 3, 2024 00:04
Copy link
Collaborator

@BillyWooo BillyWooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kailai-Wang Kailai-Wang requested a review from a team December 3, 2024 16:59
@wangminqi wangminqi enabled auto-merge (squash) December 4, 2024 01:44
@wangminqi wangminqi merged commit 68a4d70 into dev Dec 4, 2024
23 checks passed
@wangminqi wangminqi deleted the p-1020-collab-ai-curator branch December 4, 2024 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants