-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hot fix create release draft #3096
Conversation
* update path * further fix
@@ -79,7 +79,6 @@ jobs: | |||
- rococo | |||
- paseo | |||
- litentry | |||
name: ${{ matrix.chain }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have a reason of deleting this? It's good for display
@@ -148,7 +147,6 @@ jobs: | |||
- name: Save docker image | |||
run: | | |||
docker save litentry/litentry-parachain:${{ env.RELEASE_TAG }} | gzip > litentry-parachain-dev.tar.gz | |||
docker save litentry/litentry-chain-aio:${{ env.RELEASE_TAG }} | gzip > litentry-chain-aio.tar.gz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm if we don't need it in release - then we should not build it IMO
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not good practice to directly merge to dev
without an approval or without the CI check passing. Despite the title being hot fix
, It is expected to at least make sure CI is passing.
as title