Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hot fix create release draft #3096

Merged
merged 7 commits into from
Sep 25, 2024
Merged

Hot fix create release draft #3096

merged 7 commits into from
Sep 25, 2024

Conversation

BillyWooo
Copy link
Collaborator

as title

@BillyWooo BillyWooo merged commit b4df5a6 into dev Sep 25, 2024
3 checks passed
@BillyWooo BillyWooo deleted the hot-fix-create-release-draft branch September 25, 2024 21:02
@@ -79,7 +79,6 @@ jobs:
- rococo
- paseo
- litentry
name: ${{ matrix.chain }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a reason of deleting this? It's good for display

@@ -148,7 +147,6 @@ jobs:
- name: Save docker image
run: |
docker save litentry/litentry-parachain:${{ env.RELEASE_TAG }} | gzip > litentry-parachain-dev.tar.gz
docker save litentry/litentry-chain-aio:${{ env.RELEASE_TAG }} | gzip > litentry-chain-aio.tar.gz
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm if we don't need it in release - then we should not build it IMO

Copy link
Member

@felixfaisal felixfaisal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not good practice to directly merge to dev without an approval or without the CI check passing. Despite the title being hot fix, It is expected to at least make sure CI is passing.

@BillyWooo BillyWooo restored the hot-fix-create-release-draft branch September 27, 2024 10:23
@BillyWooo BillyWooo deleted the hot-fix-create-release-draft branch September 27, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants