Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introducing add_account trusted call #3155

Merged
merged 40 commits into from
Nov 4, 2024
Merged

Introducing add_account trusted call #3155

merged 40 commits into from
Nov 4, 2024

Conversation

silva-fj
Copy link
Contributor

As topic.

Most important changes:

  • New trusted call add_account: As this is a native task, we no longer need a two steps process for the identity verification.
  • The verification message now uses the parachain nonce.
  • send_to_parentchain method of the ocall_api has been refactored to allow waiting for other extrinsic statuses and to be able to return the extrinsic result.
  • Native task response (new trusted calls results) now include the extrinsic report, so clients can query the on-chain data.

silva-fj added 28 commits October 29, 2024 09:23
@silva-fj
adding get_account_nonce method to ocall_api
6ea7c78
@silva-fj
refactoring get_header ocall_api method
3dce5df
@silva-fj
refactoring omni-account repository and adding get_nonce method
b32145f
@silva-fj
adding aes256_key_repository to the native task context
7644433
@silva-fj
adding helpers for identity verification
0fca187
@silva-fj
adding add_account trusted call
5a7eae9
@silva-fj
declaring helpers module
531f109
@silva-fj
adding new error variant
9ab6cde
@silva-fj
initial setup for add_account (web3 accounts logic)
9ade8e9
@silva-fj
cleaning up unused parameters
e3fe5e1
@silva-fj
handling data verification
fe0cef6
@silva-fj
refactoring email verification, make it only compatible with onmi acc…
e77370c 
…ount
@silva-fj
removing deprecated identity_requestEmailVerification rpc method
79afe3e
@silva-fj
cleaning up helpers
39e7f13
@silva-fj
adding web2 validation data verification
8d122da
@silva-fj
cleaning up native requests
0fdb721
@silva-fj
refactoring add_account
85276be
@silva-fj
Merge remote-tracking branch 'origin/dev' into p-1120-create-add_acco…
efbcf84 
…unt-trusted-call
@silva-fj
re-ordering functions
47c2e3e
@silva-fj
adding new types to api-client-types to be able to encode substrate-a…
7534b7d 
…pi-client types
@silva-fj
refactoring send_to_parentchain to include extrinsics reports
c02a721
@silva-fj
cleaning up imports and dependencies
984742a
@silva-fj
updating send_to_parentchain on bitacross
12fb398
@silva-fj
small improvement
5b87c21
@silva-fj
cleaning up dependencies
9c8e02b
@silva-fj
returning back extrinsic report to the clients
a2af679
@silva-fj
defining TrustedCallResult type alias
c0acde3
@silva-fj
removing unused impl block
9dbac04
@silva-fj silva-fj requested review from Kailai-Wang and a team October 31, 2024 16:56
@linear Linear
Copy link

linear bot commented Oct 31, 2024

P-1120 Create `add_account` trusted call

Kailai-Wang
Kailai-Wang reviewed Nov 1, 2024
View reviewed changes
Copy link
Collaborator

@Kailai-Wang Kailai-Wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you have a very basic integration (ts) test for it? Or you could ask @0xverin to do it

@silva-fj
Copy link
Contributor Author

silva-fj commented Nov 1, 2024 •
edited
Loading

Could you have a very basic integration (ts) test for it? Or you could ask @0xverin to do it

Yes, but I think we should add the tests in a separate PR as it would require quite some changes to prepare the test suit (at least for the first test, once we have the utilities and helpers in place it would be trivial to add other test cases). Also, we could reuse what @jonalvarezz has been working on related to the omni account and the new types like TrustedCallAuthenticated, TCAuthentication, etc. Since we need to create the definitions and generate the new ts types as well

Kailai-Wang
Kailai-Wang reviewed Nov 3, 2024
View reviewed changes
Copy link
Collaborator

@Kailai-Wang Kailai-Wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good in general, I left some comments for (id-)worker, ditto for bc-worker.

The most important thing if the response_size is sufficient.

The correctness of add_account will need to be verified by ts-test

tee-worker/common/core-primitives/node-api/api-client-types/src/lib.rs Show resolved Hide resolved
tee-worker/identity/enclave-runtime/src/ocall/on_chain_ocall.rs Show resolved Hide resolved
tee-worker/bitacross/service/src/ocall_bridge/worker_on_chain_ocall.rs Outdated Show resolved Hide resolved
tee-worker/identity/litentry/core/native-task/receiver/src/lib.rs Show resolved Hide resolved
tee-worker/identity/litentry/core/native-task/receiver/src/types.rs Show resolved Hide resolved
Kailai-Wang
Kailai-Wang approved these changes Nov 4, 2024
View reviewed changes
Copy link
Collaborator

@Kailai-Wang Kailai-Wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with it, we are good to go after conflicts are resolved

@silva-fj silva-fj enabled auto-merge (squash) November 4, 2024 16:49
@silva-fj silva-fj merged commit 4905e01 into dev Nov 4, 2024
21 checks passed
@silva-fj silva-fj deleted the p-1120-create-add_account-trusted-call branch November 4, 2024 16:56
@jonalvarezz jonalvarezz mentioned this pull request Nov 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kailai-Wang Kailai-Wang Kailai-Wang approved these changes

@kziemianek kziemianek kziemianek approved these changes

@jonalvarezz jonalvarezz Awaiting requested review from jonalvarezz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@silva-fj @kziemianek @Kailai-Wang