Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back bitacross-worker for paseo #3209

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Conversation

Kailai-Wang
Copy link
Collaborator

Context

As topic - it's still required for some service.

@Kailai-Wang Kailai-Wang requested review from kziemianek and a team December 17, 2024 09:39
@Kailai-Wang Kailai-Wang self-assigned this Dec 17, 2024
@Kailai-Wang
Copy link
Collaborator Author

btw @kziemianek

I just noticed if we want to remove the bc-worker cleanly, we have to do proper migration, otherwise we have wrong type info and the old bc-workers appear under OmniExecutor type in teebag:
image

@kziemianek
Copy link
Member

kziemianek commented Dec 17, 2024

We either explicitly assing indices as here or write migration / do it by hand.

It happens becuase if indices are not explicitly set the OmniExecutor variant gets index 1 in new version which was previously assigned to bitacross - thus bitacross are displayed as omni executor workers

@Kailai-Wang Kailai-Wang merged commit 7091513 into dev Dec 17, 2024
22 checks passed
@Kailai-Wang Kailai-Wang deleted the add-back-bitacross-in-paseo branch December 17, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants