Updating client libraries to add auth token authentication support #3219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still in WIP?Or did you forget to change the state? Just to confirm if a review is needed |
Yep, this is still WIP. I'm currently working on the client-sdk part. Thank you for checking 👍🏼 |
|
I've realised that more changes are needed. |
|
@0xverin could you please take a look? |
0xverin
reviewed
Jan 2, 2025
| @@ -21,9 +25,11 @@ export function createTCAuthenticationType( | |||
| [data.type]: | |||
| data.type === 'Email' | |||
| ? data.verificationCode | |||
| : createLitentryMultiSignature(registry, { | |||
| : data.type === 'Web3' | |||
There was a problem hiding this comment.
How about changing it to map or switch case? It might be more intuitive. I think there might be additional types added here in the future.
for example:
const getValue = () => {
switch (data.type) {
case 'Email':
return data.verificationCode;
case 'Web3':
return createLitentryMultiSignature(registry, {
who: data.signer,
signature: data.signature,
});
default:
return data.token;
}
};
[data.type]: getValue()
| @@ -104,13 +107,13 @@ is the signed payload. | |||
|
|
|||
| #### Defined in | |||
|
|
|||
| [lib/requests/call-ethereum.request.ts:31](https://github.com/litentry/client-sdk/blob/develop/lib/requests/call-ethereum.request.ts#L31) | |||
| [lib/requests/call-ethereum.request.ts:32](https://github.com/litentry/client-sdk/blob/develop/lib/requests/call-ethereum.request.ts#L32) | |||
0xverin
reviewed
Jan 2, 2025
| @@ -5,7 +5,7 @@ | |||
| "main": "dist/src/index.js", | |||
| "module": "dist/src/index.js", | |||
| "sideEffects": false, | |||
| "version": "0.9.21-next.0", | |||
| "version": "0.9.21-next.3", | |||
There was a problem hiding this comment.
Please add the update content in the changelog file.Thank you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated packages:
parachain-api: https://www.npmjs.com/package/@litentry/parachain-api/v/0.9.21-next.3client-sdk: https://www.npmjs.com/package/@litentry/client-sdk/v/1.0.0-next.10Also the client-sdk workspace have been fixed. (The build process was broken due to a mismatch in the nx dependencies version`