Skip to content

Revert conditional docker-login step in CI #3779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 22, 2025
Merged

Revert conditional docker-login step in CI #3779

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
04c57dd
Revert "Remove condition in docker-login ci (#3776)"
Kailai-Wang Oct 22, 2025
ae1ed62
fix clippy
Kailai-Wang Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -551,12 +551,6 @@ jobs:
if: startsWith(runner.name, 'GitHub Actions')
uses: ./.github/actions/disk-cleanup

- name: Dockerhub login
uses: docker/login-action@v3
with:
username: ${{ secrets.DOCKERHUB_USERNAME }}
password: ${{ secrets.DOCKERHUB_PASSWORD }}

- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3
with:
Expand All @@ -576,6 +570,13 @@ jobs:
build-args: |
CARGO_FEATURES=mock-server

- name: Dockerhub login
if: needs.set-condition.outputs.rebuild_omni_executor == 'false'
uses: docker/login-action@v3
with:
username: ${{ secrets.DOCKERHUB_USERNAME }}
password: ${{ secrets.DOCKERHUB_PASSWORD }}

- name: Pull omni-executor image optionally
if: needs.set-condition.outputs.rebuild_omni_executor == 'false'
run: |
Expand Down
36 changes: 18 additions & 18 deletions parachain/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.