-
Notifications
You must be signed in to change notification settings - Fork 18
Refactor to remove native task wrapper #3780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Claude encountered an error —— View job PR Review: Refactor to remove native task wrapper
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM

Context
Fixes P-1717
This PR tries to remove teh NativeTaskWrapper (and thus
native-task-handler) completely by inlining the handling directly in rpc method handler.With help-check of claude It tries to keep the error handling backwards compatible/same so we don't return e.g. different error code, but much of the code is not used so I'm not 100% sure if it covers all cases strictly, as I indeed find some unused error codes in
error_code.rsSome more clean-ups:
client_idin middleware auth is actually not used, so I unwrap thestruct Userto use the underlyingomni_accountdirectlyomni_submitNativeTaskis removed, together with task primitives definitionsethereum-intent-executorandsolana-intent-executorare removed fromstart_serverandRpcContext