Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automation extrinisic pallet ordering checking #719

Merged

Conversation

chenzongxiong
Copy link
Contributor

@chenzongxiong chenzongxiong commented Jul 20, 2022

Currently, we can compare metadata of parachain on the production with the one to be released and automatically comment the corresponding release checklist.

NOTE:
release checklist issue MUST be created before running create release draft action, otherwise, metadata comparison cannot perform correctly

Check the following results, we can confirm that this action can perform correctly
https://github.com/litentry/litentry-parachain/actions/runs/2743075428

Litentry-parachain v0.9.7 Release checklist

@chenzongxiong chenzongxiong linked an issue Jul 20, 2022 that may be closed by this pull request
2 tasks
@chenzongxiong chenzongxiong changed the title check litentry & litmus at the same time Automation extrinisic pallet ordering checking Jul 20, 2022
Copy link
Collaborator

@Kailai-Wang Kailai-Wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow is fine, but the main problem is the comparing URL

.github/workflows/extrinsic-ordering-check-from-bin.yml Outdated Show resolved Hide resolved
.github/workflows/extrinsic-ordering-check-from-bin.yml Outdated Show resolved Hide resolved
.github/workflows/extrinsic-ordering-check-from-bin.yml Outdated Show resolved Hide resolved
.github/workflows/extrinsic-ordering-check-from-bin.yml Outdated Show resolved Hide resolved
.github/workflows/extrinsic-ordering-check-from-bin.yml Outdated Show resolved Hide resolved
@chenzongxiong chenzongxiong changed the title Automation extrinisic pallet ordering checking [WIP] Automation extrinisic pallet ordering checking Jul 22, 2022
@chenzongxiong chenzongxiong force-pushed the 577-automation-extrinsic-pallet-order-check-when-release branch from 23ff2e7 to 04d928c Compare July 25, 2022 06:55
@chenzongxiong chenzongxiong force-pushed the 577-automation-extrinsic-pallet-order-check-when-release branch 13 times, most recently from ecae2c1 to bc628d7 Compare July 26, 2022 22:57
@chenzongxiong chenzongxiong force-pushed the 577-automation-extrinsic-pallet-order-check-when-release branch 6 times, most recently from bc3c86f to c215080 Compare July 26, 2022 23:33
@chenzongxiong chenzongxiong force-pushed the 577-automation-extrinsic-pallet-order-check-when-release branch from c215080 to 7eb8a6a Compare July 26, 2022 23:33
@chenzongxiong chenzongxiong changed the title [WIP] Automation extrinisic pallet ordering checking Automation extrinisic pallet ordering checking Jul 26, 2022
@chenzongxiong
Copy link
Contributor Author

The workflow is fine, but the main problem is the comparing URL

fixed.

@chenzongxiong chenzongxiong added S1-pleasereview D3-chore tasks that need to be completed but don’t provide any additional features/functionality labels Jul 27, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #719 (ba967ad) into dev (0484dd4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #719   +/-   ##
=======================================
  Coverage   95.95%   95.95%           
=======================================
  Files          12       12           
  Lines        1683     1683           
=======================================
  Hits         1615     1615           
  Misses         68       68           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0484dd4...ba967ad. Read the comment docs.

.github/workflows/create-release-draft.yml Outdated Show resolved Hide resolved
.github/workflows/create-release-draft.yml Outdated Show resolved Hide resolved
.github/workflows/create-release-draft.yml Outdated Show resolved Hide resolved
@chenzongxiong chenzongxiong force-pushed the 577-automation-extrinsic-pallet-order-check-when-release branch from b609462 to 1045081 Compare July 27, 2022 20:39
@chenzongxiong chenzongxiong force-pushed the 577-automation-extrinsic-pallet-order-check-when-release branch from 1045081 to b125152 Compare July 27, 2022 20:46
@Kailai-Wang Kailai-Wang merged commit 4939185 into dev Jul 27, 2022
@Kailai-Wang Kailai-Wang deleted the 577-automation-extrinsic-pallet-order-check-when-release branch July 27, 2022 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
D3-chore tasks that need to be completed but don’t provide any additional features/functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automation of entrinsic and pallet order check
3 participants