feat: chainbridge linked to new binary for CI test #1376
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillyWooo
reviewed
Feb 26, 2023
| @@ -123,9 +123,9 @@ async function setupCrossChainTransfer( | |||
| await eConfig.erc20.mint(eConfig.wallets.eve.address, toWei('100000')); | |||
| await eConfig.erc20.mint(eConfig.erc20Handler.address, toWei('300')); | |||
| await eConfig.bridge.adminSetResource(eConfig.erc20Handler.address, destResourceId, eConfig.erc20.address); | |||
| await eConfig.bridge.adminSetDecimals(eConfig.erc20Handler.address, eConfig.erc20.address, 18, 12, opts); | |||
| // await eConfig.bridge.adminSetDecimals(eConfig.erc20Handler.address, eConfig.erc20.address, 18, 12, opts); | |||
There was a problem hiding this comment.
If this ain't needed, please remove it altogether :)
| @@ -82,16 +82,24 @@ describeCrossChainTransfer('Test Cross-chain Transfer', ``, (context) => { | |||
| const provider = context.ethConfig.wallets.alice.provider; | |||
| const currentBlock = await provider.getBlockNumber(); | |||
| await sleep(15); | |||
|
|
|||
| let voteTransactionCount = 0; | |||
There was a problem hiding this comment.
What's this counter for? The loop stops after the first voteTransaction anyway, so at the if (voteTransactionCount === 1) { part voteTransactionCount will always equal 1 🤔
| if (decodedInput.name === 'voteProposal') { | ||
| voteTransactionCount++; | ||
| // We have threshold = 1 in this. So it really does not matter | ||
| if (voteTransactionCount === 1) { |
There was a problem hiding this comment.
💅 the intent can be made a bit more explicit by
Suggested change
| if (voteTransactionCount === 1) { | |
| if (voteTransactionCount === approvalThreshold) { |
with a const approvalThreshold = 1 earlier
|
This PR is not urgent and we will not change token bridge code in short time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for linking chainbridge ts test to latest binary.
In order to properly view this PR. Request code review in
Chainbridge Binary Change
litentry/ChainBridge#2
Chainbridge Solidity Change
litentry/chainbridge-solidity#1