Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ubuntu 20 as the docker base image #2124 #2134

Closed
wants to merge 8 commits into from
Closed

Use ubuntu 20 as the docker base image #2124 #2134

wants to merge 8 commits into from

Conversation

songzhouran
Copy link
Contributor

@songzhouran songzhouran commented Sep 14, 2023 •
edited
Loading

Context

resolves #2124

@Kailai-Wang
Copy link
Collaborator

I'd suggest that you add more details to this PR, as we can't infer any by just looking at the PR itself:

  • the title is build, all historical commits are build too
  • the PR description doesn't contain much information
  • it's not linked to any issue

That's a bad example of PR if I'm frank :(

@songzhouran songzhouran changed the title build Use ubuntu 20 as the docker base image #2124 Sep 18, 2023
Kailai-Wang
Kailai-Wang requested changes Sep 21, 2023
View reviewed changes
Copy link
Collaborator

@Kailai-Wang Kailai-Wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think runs-on images in yml are irrelevant. We only care about the final image of our parachain for now

.github/workflows/benchmark-runtime-weights.yml Outdated Show resolved Hide resolved
docker/Dockerfile Outdated Show resolved Hide resolved
docker/Dockerfile Outdated Show resolved Hide resolved
@wangminqi
Copy link
Member

wangminqi commented Sep 25, 2023 •
edited
Loading

Currently, T40 is Ubuntu 22.04.
I am not sure if the solution back to Ubuntu 20 as the base image is a good idea. (Up to you guys)
PS: bump to Ubuntu 22.04 from 18 was made by me to solve a similar GLIBC not-found issue in the first place.

@Kailai-Wang
Copy link
Collaborator

I see this: https://github.com/litentry/litentry-parachain/actions/runs/6331837822/job/17197287030

so most likely the rust:latest isn't the right image anymore (= it's based on ubuntu 22 too)

@songzhouran
Copy link
Contributor Author

I tried to print ubuntu version in rust 1.20 image, found it is still ubuntu22. Are all available rust image based on ubuntu22?
Uploading build.PNG…

@songzhouran
Copy link
Contributor Author

Sending build context to Docker daemon 2.048kB
Step 1/3 : FROM rust:1.20.0
1.20.0: Pulling from library/rust
3e17c6eae66c: Pull complete
74d44b20f851: Pull complete
a156217f3fa4: Pull complete
4a1ed13b6faa: Pull complete
c6defea3d225: Pull complete
e2bfce1bb665: Pull complete
Digest: sha256:92544708124a7568afe04b2cf1c9c35f781a700ecb9affd2c36c50d08c63bd81
Status: Downloaded newer image for rust:1.20.0
---> 78e857abc533
Step 2/3 : LABEL maintainer="Trust"
---> Running in 114e4a51d8f5
Removing intermediate container 114e4a51d8f5
---> 9000fc6738a9
Step 3/3 : RUN cat /proc/version
---> Running in 9d79035648f7
Linux version 5.15.0-82-generic (buildd@lcy02-amd64-027) (gcc (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0, GNU ld (GNU Binutils for Ubuntu) 2.38) #91-Ubuntu SMP Mon Aug 14 14:14:14 UTC 2023
Removing intermediate container 9d79035648f7
---> d47b42b225a2
Successfully built d47b42b225a2

@Kailai-Wang
Copy link
Collaborator

superseded by #2170

@Kailai-Wang Kailai-Wang deleted the build branch September 29, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kailai-Wang Kailai-Wang Awaiting requested review from Kailai-Wang

@kziemianek kziemianek Awaiting requested review from kziemianek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use ubuntu 20 as the docker base image
4 participants
@songzhouran @Kailai-Wang @wangminqi @kziemianek