-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply caching for enclave CI build #2156
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kziemianek
approved these changes
Sep 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work. In general it looks fine to me, just one small comment which can be resolved in separate PR if really needed..
BillyWooo
approved these changes
Sep 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 great work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
resolves #2140
This PR applies the caching mechanism to the enclave builds in CI after some research:
ci.yml
Here's an informative summary of the problem and its background, including possible solutions(workarounds): https://hackmd.io/@kobzol/S17NS71bh
In this PR, a plain copy in/out of cached data to/from docker image is performed and persisted via the official
action/cache
GHA. Things that are cached:$CARGO_HOME/registry/index
$CARGO_HOME/registry/cache
$CARGO_HOME/git/db
sccache
artifactsApart from that, this PR uses a few more techs to make it possible/more efficient:
Working example: this is a re-run with small changes to the original code:
https://github.com/litentry/litentry-parachain/actions/runs/6274181997/job/17039285320
Compilation was done within 15min, and this is the sccache stats:
There are still a few TODOs, I'll create follow-up issues.