feat: use threadpools for STF Tasks #2159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixfaisal
changed the title
kziemianek
approved these changes
Sep 26, 2023
| let context_for_thread = context.clone(); | ||
| std::thread::spawn(move || loop { | ||
| if let Ok((shard, hash, call)) = to_receiver.recv() { | ||
| error!("Submitting trusted call to the pool"); |
There was a problem hiding this comment.
@felixfaisal can this be debug or trace or maybe even removed?
Imho this log entry doesn't provide any useful information and will only spawn logs.
Kailai-Wang
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1958
Utilizing a threadpool offers a notable advantage over executing tasks sequentially, particularly in scenarios that are I/O-bound or involve a combination of I/O and CPU operations. One of the primary strengths of a threadpool is its ability to distribute tasks effectively. When faced with tasks of varying durations, a threadpool can evenly distribute the workload across its threads, ensuring that no single thread is disproportionately burdened.
However, this concurrency presents a challenge: when multiple tasks attempt to submit trusted calls, nonce conflicts can arise.
To address this challenge, I've implemented an MPSC channel. By routing submissions through a single receiver thread, we can maintain the asynchronicity of task completions while ensuring that trusted call submissions don't encounter nonce conflicts. By having tasks only signal their completion through these channels, rather than submitting trusted calls directly, we've effectively introduced a layer that ensures ordered submissions, resolving the nonce conflict issue.