Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup deps #2166

Merged
merged 9 commits into from
Sep 29, 2023
Merged

Cleanup deps #2166

merged 9 commits into from
Sep 29, 2023

Conversation

kziemianek
Copy link
Member

@kziemianek kziemianek commented Sep 27, 2023

Some dependencies are not needed anymore, some can be trated as dev dependencies only, for example if they are used in tests only.

This PR tries to tidy Cargo.toml files a little bit which might eventually lead to:

  • better developer experience
  • shorten build times

I've applied rustc lint rule to modules one by one to see what deps are not used.

This rule cannot be toggled on because it might produce false-positives depending on specified build features.

@kziemianek kziemianek requested a review from a team September 27, 2023 09:09
@Kailai-Wang
Copy link
Collaborator

Thank you! I'm wondering if there's any tool for it? Not necessarily integrated in CI but we can use it locally at least

@kziemianek
Copy link
Member Author

Thank you! I'm wondering if there's any tool for it? Not necessarily integrated in CI but we can use it locally at least

Yes 🙃 previously I tried with rustc lint rule but I found out machete to be really acurate. I had also exerimented with udeps but without a success.

Copy link
Collaborator

@Kailai-Wang Kailai-Wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my side 👍

@Kailai-Wang Kailai-Wang merged commit aaebc6f into dev Sep 29, 2023
28 checks passed
@Kailai-Wang Kailai-Wang deleted the cleanup-deps branch September 29, 2023 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants