Remove unused dep from node #2171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
resolves #2167
I went through the unused crates one by one to make sure we didn't need them. I compared it with polkadot-sdk and/or other parachains too.
Standard crates that are simply not referenced:
Unused deps introduced by evm change
Unused cumulus deps in our case:
The main divergence here is if we should use the AuraVerifier from substrate, or a wrapped Verifier which has an additional relay_chain_verifier in case the client doesn't have aura. But since we use aura (same as the majority of parachains), it doesn't matter so much - we can keep our current implementation.
However, we are not saving a lot of compilation time and many crates are still indirectly referenced, see the changes in
Cargo.lock