Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark request-vc cli command #3016

Merged

Conversation

kziemianek
Copy link
Member

Simple CLI command to run benchmark of request-vc command.

@kziemianek kziemianek requested a review from a team August 26, 2024 07:25
Copy link

linear bot commented Aug 26, 2024

Copy link
Collaborator

@Kailai-Wang Kailai-Wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - I'm wondering what's the time for EVM assertion :D

tee-worker/cli/src/benchmark/direct_request_vc.rs Outdated Show resolved Hide resolved
tee-worker/cli/src/benchmark/direct_request_vc.rs Outdated Show resolved Hide resolved
tee-worker/cli/src/benchmark/direct_request_vc.rs Outdated Show resolved Hide resolved
@kziemianek
Copy link
Member Author

Looks good - I'm wondering what's the time for EVM assertion :D

Looks promising, times are almost equal for A1

kziemianek@kziemianek:~/projects/litentry/litentry-parachain/tee-worker/target/release$ ./litentry-cli trusted benchmark-request-vc 8 400 did:litentry:substrate:0x8eaf04151687736326c9fea17e25fc5287613693c912909cb226aa4794f26a48 a1
Running request_vc benchmarking
Total time: 18.0592s
Average request vc time is: 0.0451s
Errors count: 0
kziemianek@kziemianek:~/projects/litentry/litentry-parachain/tee-worker/target/release$ ./litentry-cli trusted benchmark-request-vc 8 400       did:litentry:substrate:0x8eaf04151687736326c9fea17e25fc5287613693c912909cb226aa4794f26a48       dynamic 0000000000000000000000000000000000000000
Running request_vc benchmarking
Total time: 18.1130s
Average request vc time is: 0.0451s
Errors count: 0

@kziemianek kziemianek enabled auto-merge (squash) August 28, 2024 11:38
@kziemianek kziemianek merged commit 9e893a2 into dev Aug 28, 2024
34 checks passed
@kziemianek kziemianek deleted the p-1004-benchmark-command-to-measure-request_vc-performance branch August 28, 2024 13:53
@higherordertech
Copy link
Contributor

The benchmark LGTM
I am also wondering the result diff for token-holding-amount VC, as the time-consuming operation mostly caused by third-party API calls

@kziemianek
Copy link
Member Author

kziemianek commented Aug 29, 2024

@higherordertech here are results for BNB token holding with mocked nodereal instance:

Preparation:

./litentry-cli trusted -d link-identity did:litentry:substrate:0x8eaf04151687736326c9fea17e25fc5287613693c912909cb226aa4794f26a48 did:litentry:evm:0x0D9bFD1f18f5f4FD08247DC54aD3528909c4b3E9 bsc,ethereum
./litentry-cli trusted -d link-identity did:litentry:substrate:0x8eaf04151687736326c9fea17e25fc5287613693c912909cb226aa4794f26a48 did:litentry:evm:0x0D9bFD1f18f5f4FD08247DC54aD3528909c4b3EA bsc,ethereum


Results:

kziemianek@kziemianek:~/projects/litentry/litentry-parachain/tee-worker/target/release$ ./litentry-cli trusted benchmark-request-vc 8 400 did:litentry:substrate:0x8eaf04151687736326c9fea17e25fc5287613693c912909cb226aa4794f26a48 token-
holding-amount bnb
Running request_vc benchmarking
Total time: 18.1449s
Average request vc time is: 0.0452s
Errors count: 0
kziemianek@kziemianek:~/projects/litentry/litentry-parachain/tee-worker/target/release$ ./litentry-cli trusted benchmark-request-vc 8 400 did:litentry:substrate:0x8eaf04151687736326c9fea17e25fc5287613693c912909cb226aa4794f26a48 dynamic 0000000000000000000000000000000000000000 00000000000000000000000000000000000000000000000000000000000000200000000000000000000000000000000000000000000000000000000000000003626e620000000000000000000000000000000000000000000000000000000000
Running request_vc benchmarking
Total time: 18.3935s
Average request vc time is: 0.0455s
Errors count: 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants