-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handling missing branch for Email identity in match patterns #3064
Conversation
FYI this release branch was already broken, some changes related to https://github.com/litentry/litentry-parachain/actions/runs/10826722348/job/30038362291 I don't know what is missing, I have not checked the commit history |
I think the error reported it clearly:
|
Yep, what I meant is that I don't know the full context of these changes. In dev branch this variant is also not covered so I assume this is some work in progress (I don't know what the value for that schema should be) |
I think @higherordertech updated the release branch due to the same reason that you have - he wanted to update the primitives to include another entry (but probably only the enum itself, not the places where it's referenced, hence the error) |
The error is clear. But strange, why this #3042 passed. |
737f273
to
a922aec
Compare
|
Signed-off-by: Jonathan Alvarez <jonathan@litentry.com>
* feat: P-1006 add new Assertion enum item LinkedIdentities (#3042) (#3051) Co-authored-by: higherordertech <higherordertech> * adding email identity to core primitives (#3063) * adding email identity to core primitives * fixing formatting issue * Handling missing enum branches in match patterns (#3064) Handling missing variants for LinkedIdentities and Identity in match patterns * re-apply changes from #3064 after restructure Signed-off-by: Jonathan Alvarez <jonathan@litentry.com> --------- Signed-off-by: Jonathan Alvarez <jonathan@litentry.com> Co-authored-by: will.li <120463031+higherordertech@users.noreply.github.com> Co-authored-by: Francisco Silva <franjs.francisco@gmail.com>
No description provided.