m) Fix: read_ctx maybe accessed after free #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@litespeedtech @gwanglst Please check this PR, thanks! |
read_ctx maybe accessed after free in the following situation: 1) First: qdec_header_process got LQRHS_BLOCKED(like: Required Insert Count not enough, here we assume RIC is 17) from qdec_read_header, and then stash_blocked_header, which means that read_ctx will be inserted to dec->qpd_blocked_headers[id] 2) Second: qdec_header_process got LSRHS_ERROR(like: QPACK decompression error), then it call qdec_remove_header_block and free read_ctx, but read_ctx still be retained in qpd_blocked_headers list 3) Third: RIC 17 is ready, then it will call qdec_process_blocked_headers, and here above read_ctx will be accessed again, but its memory is invalid, which will be coredump.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
read_ctx maybe accessed after free in the following situation: