-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can lsquic provide an api to get connection sni? #203
Labels
Comments
It would be easier to discuss your proposal if it were a PR: then we could look at actual code. |
Closed
I created a pull request that should implement this feature, providing a method const char* lsquic_conn_get_sni(struct lsquic_conn*); Cheers |
litespeedtech
pushed a commit
that referenced
this issue
Jan 11, 2021
litespeedtech
pushed a commit
that referenced
this issue
Jan 13, 2021
- [API] Add lsquic_conn_get_sni(), fixes issue #203.
Fixed in 2.27.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When on_new_conn be called, I hope lsquic can have an api to get sni from conn, which same with the 3rd ea_lookup_cert para.
like: lsquic_conn_get_hostname or lsquic_conn_get_sni
I try to add new api, but I find enc_session->hs_ctx.sni.str maybe changed occasionally before on_new_conn be called.
I have following code by gdb, and sure that destroy_conn(mini conn) is called after on_new_conn be called, So I'm puzzled here.
What I have changed to lsquic:
Add a new elem "hostname" to struct lsquic_conn
in func get_sni_SSL_CTX, I save sni to mini conn;
enc_session->es_conn->hostname = enc_session->hs_ctx.sni.str;
in func lsquic_gquic_full_conn_server_new, deliver sni to full conn from mini conn
conn->fc_conn.hostname = lconn_mini->hostname;
on_new_conn, I get sni from conn
The text was updated successfully, but these errors were encountered: