Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it easier to include boringssl and lsquic via add_subdirectory() #354

Merged
merged 1 commit into from
Apr 23, 2022
Merged

Make it easier to include boringssl and lsquic via add_subdirectory() #354

merged 1 commit into from
Apr 23, 2022

Commits on Jan 13, 2022

  1. Make it easier to include boringssl and lsquic via add_subdirectory() 

    FIND_LIBRARY will fail if boringssl didn't get build yet, so the
following cmake build rule doesn't work:

add_subdirectory(third_party/boringssl)
set(BORINGSSL_LIB ${CMAKE_CURRENT_BINARY_DIR}/third_party/boringssl)
add_subdirectory(third_party/lsquic)

The patch fixed it by allow setting BORINGSSL_LIB_foo explicitly,
e.g.,
add_subdirectory(third_party/boringssl)
set(BORINGSSL_LIB_ssl ssl)
set(BORINGSSL_LIB_crypto crypto)
set(BORINGSSL_LIB_decrepit decrepit)
add_subdirectory(third_party/lsquic)
    @quink-black
    quink-black committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    86d1ea1 View commit details
    Browse the repository at this point in the history