Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: move to PDM #2357

Merged
merged 18 commits into from
Oct 7, 2023
Merged

ci: move to PDM #2357

merged 18 commits into from
Oct 7, 2023

Conversation

JacobCoffee
Copy link
Member

@JacobCoffee JacobCoffee commented Sep 25, 2023 •
edited
Loading

Pull Request Checklist

  • New code has 100% test coverage
  • (If applicable) The prose documentation has been updated to reflect the changes introduced by this PR
  • (If applicable) The reference documentation has been updated to reflect the changes introduced by this PR

Description

  • Moves the development toolchain to use PDM with hatchling as the build backend

Close Issue(s)

@JacobCoffee JacobCoffee requested review from a team as code owners September 25, 2023 04:52
@JacobCoffee
Copy link
Member Author

This was done on my Windows desktop so I couldnt run pre-commit, im sure there are some issues but I will try to resolve them tomorrow.

p.s. Windows PATH sucks, installing things sucks, and I hate everything about it

@Xemnas0
Copy link

Xemnas0 commented Sep 25, 2023

Can I ask the motivations behind this decision?

@JacobCoffee
Copy link
Member Author

Can I ask the motivations behind this decision?

Poetry speed issue and bugs were part of our frustrations. Dep. resolution being one of the big ones..
There are some Discord threads and GH Issue: #2219

@JacobCoffee
Copy link
Member Author

JacobCoffee commented Oct 4, 2023 •
edited
Loading

Looks ready

@JacobCoffee JacobCoffee changed the title infra: move to PDM ci: move to PDM Oct 4, 2023
cofin
cofin reviewed Oct 4, 2023
View reviewed changes
Makefile Outdated Show resolved Hide resolved
cofin
cofin reviewed Oct 4, 2023
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
cofin
cofin reviewed Oct 4, 2023
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
cofin
cofin reviewed Oct 4, 2023
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
cofin
cofin reviewed Oct 4, 2023
View reviewed changes
.github/workflows/docs.yaml Outdated Show resolved Hide resolved
cofin
cofin reviewed Oct 4, 2023
View reviewed changes
.github/workflows/test.yaml Outdated Show resolved Hide resolved
JacobCoffee and others added 3 commits October 3, 2023 23:47
@JacobCoffee @cofin
Update Makefile
86125e1 
Co-authored-by: Cody Fincher <204685+cofin@users.noreply.github.com>
@JacobCoffee @cofin
Update pyproject.toml
6a33f20 
Co-authored-by: Cody Fincher <204685+cofin@users.noreply.github.com>
@JacobCoffee @cofin
Update pyproject.toml
5b31c7e 
Co-authored-by: Cody Fincher <204685+cofin@users.noreply.github.com>
cofin
cofin approved these changes Oct 7, 2023
View reviewed changes
Copy link
Member

@cofin cofin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. I think this is ready to go.

@sonarcloud
Copy link

sonarcloud bot commented Oct 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link

github-actions bot commented Oct 7, 2023

Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/2357

Alc-Alc
Alc-Alc approved these changes Oct 7, 2023
View reviewed changes
Copy link
Contributor

@Alc-Alc Alc-Alc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@JacobCoffee JacobCoffee merged commit a35d392 into main Oct 7, 2023
18 checks passed
@JacobCoffee JacobCoffee deleted the pdm branch October 7, 2023 01:59
peterschutt added a commit that referenced this pull request Nov 17, 2023
@peterschutt
chore: make test use multiple cores.
682ee3c 
In the move to PDM in #2357 `make test` was modified to run `pytest tests` from `pytest tests -n auto`.

This appears to have been inadvertent, so this PR changes it back.
@peterschutt peterschutt mentioned this pull request Nov 17, 2023
Merged
5 tasks
peterschutt added a commit that referenced this pull request Nov 18, 2023
@peterschutt
chore: make test use multiple cores. (#2696)
38b35ad 
In the move to PDM in #2357 `make test` was modified to run `pytest tests` from `pytest tests -n auto`.

This appears to have been inadvertent, so this PR changes it back.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alc-Alc Alc-Alc Alc-Alc approved these changes

@cofin cofin cofin approved these changes

@provinzkraut provinzkraut Awaiting requested review from provinzkraut

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Infrastructure: replace poetry
5 participants
@JacobCoffee @Xemnas0 @cofin @provinzkraut @Alc-Alc