Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: Remove deprecated StaticFileConfig #3357

Merged
merged 10 commits into from
Apr 10, 2024

Conversation

provinzkraut
Copy link
Member

Removes the deprecated static_files_config and friends.

(please don't merge yet, this needs some docs and a better description 🙂)

@provinzkraut provinzkraut added the do not merge Don't merge this label Apr 9, 2024
@provinzkraut provinzkraut requested review from a team as code owners April 9, 2024 17:06
@JacobCoffee
Copy link
Member

JacobCoffee commented Apr 9, 2024

Could you potentially wait and rebase against main or #3358 before doing remaining docs-related tings? no big deal if not

@peterschutt
Copy link
Contributor

peterschutt commented Apr 9, 2024

I've started a "What's new in 3.0" document in #3297 (also needing review 😉) Disregard, this is in #3324

@provinzkraut provinzkraut force-pushed the remove-static-files-app branch from 0c4c32b to d88c1d1 Compare April 10, 2024 17:10
@github-actions github-actions bot added area/contrib This PR involves changes to the contrib (Deprecated) area/docs This PR involves changes to the documentation area/handlers This PR involves changes to the handlers area/middleware This PR involves changes to the middleware area/private-api This PR involves changes to the privatized API size: large area/template area/static-files area/connection area/testing pr/internal labels Apr 10, 2024
Copy link

codecov bot commented Apr 10, 2024

Codecov Report

Attention: Patch coverage is 98.63014% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 98.24%. Comparing base (622b53b) to head (e69c376).

❗ Current head e69c376 differs from pull request most recent head 86501dc. Consider uploading reports for the commit 86501dc to get more accurate results

Files Patch % Lines
litestar/static_files.py 98.57% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             v3.0    #3357      +/-   ##
==========================================
- Coverage   98.28%   98.24%   -0.04%     
==========================================
  Files         323      321       -2     
  Lines       14773    14687      -86     
  Branches     2345     2334      -11     
==========================================
- Hits        14519    14429      -90     
  Misses        116      116              
- Partials      138      142       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@provinzkraut provinzkraut force-pushed the remove-static-files-app branch from 263c4c2 to cec9396 Compare April 10, 2024 17:20
@provinzkraut provinzkraut removed the do not merge Don't merge this label Apr 10, 2024
provinzkraut added a commit that referenced this pull request Nov 28, 2024
* Remove deprecated StaticFiles and StaticFilesConfig
* remove special casing of static files app from handlers/router
* remove outdated docs sections
* Add what's new section
* Rename tests for consistency
provinzkraut added a commit that referenced this pull request Nov 29, 2024
* Remove deprecated StaticFiles and StaticFilesConfig
* remove special casing of static files app from handlers/router
* remove outdated docs sections
* Add what's new section
* Rename tests for consistency
provinzkraut added a commit that referenced this pull request Dec 12, 2024
* Remove deprecated StaticFiles and StaticFilesConfig
* remove special casing of static files app from handlers/router
* remove outdated docs sections
* Add what's new section
* Rename tests for consistency
provinzkraut added a commit that referenced this pull request Dec 13, 2024
* Remove deprecated StaticFiles and StaticFilesConfig
* remove special casing of static files app from handlers/router
* remove outdated docs sections
* Add what's new section
* Rename tests for consistency
provinzkraut added a commit that referenced this pull request Dec 13, 2024
* Remove deprecated StaticFiles and StaticFilesConfig
* remove special casing of static files app from handlers/router
* remove outdated docs sections
* Add what's new section
* Rename tests for consistency
provinzkraut added a commit that referenced this pull request Dec 13, 2024
* Remove deprecated StaticFiles and StaticFilesConfig
* remove special casing of static files app from handlers/router
* remove outdated docs sections
* Add what's new section
* Rename tests for consistency
provinzkraut added a commit that referenced this pull request Jan 11, 2025
* Remove deprecated StaticFiles and StaticFilesConfig
* remove special casing of static files app from handlers/router
* remove outdated docs sections
* Add what's new section
* Rename tests for consistency
provinzkraut added a commit that referenced this pull request Jan 11, 2025
* Remove deprecated StaticFiles and StaticFilesConfig
* remove special casing of static files app from handlers/router
* remove outdated docs sections
* Add what's new section
* Rename tests for consistency
provinzkraut added a commit that referenced this pull request Jan 11, 2025
* Remove deprecated StaticFiles and StaticFilesConfig
* remove special casing of static files app from handlers/router
* remove outdated docs sections
* Add what's new section
* Rename tests for consistency
provinzkraut added a commit that referenced this pull request Jan 11, 2025
* Remove deprecated StaticFiles and StaticFilesConfig
* remove special casing of static files app from handlers/router
* remove outdated docs sections
* Add what's new section
* Rename tests for consistency
provinzkraut added a commit that referenced this pull request Jan 11, 2025
* Remove deprecated StaticFiles and StaticFilesConfig
* remove special casing of static files app from handlers/router
* remove outdated docs sections
* Add what's new section
* Rename tests for consistency
provinzkraut added a commit that referenced this pull request Jan 11, 2025
* Remove deprecated StaticFiles and StaticFilesConfig
* remove special casing of static files app from handlers/router
* remove outdated docs sections
* Add what's new section
* Rename tests for consistency
provinzkraut added a commit that referenced this pull request Jan 11, 2025
* Remove deprecated StaticFiles and StaticFilesConfig
* remove special casing of static files app from handlers/router
* remove outdated docs sections
* Add what's new section
* Rename tests for consistency
provinzkraut added a commit that referenced this pull request Jan 15, 2025
* Remove deprecated StaticFiles and StaticFilesConfig
* remove special casing of static files app from handlers/router
* remove outdated docs sections
* Add what's new section
* Rename tests for consistency
provinzkraut added a commit that referenced this pull request Jan 15, 2025
* Remove deprecated StaticFiles and StaticFilesConfig
* remove special casing of static files app from handlers/router
* remove outdated docs sections
* Add what's new section
* Rename tests for consistency
provinzkraut added a commit that referenced this pull request Jan 15, 2025
* Remove deprecated StaticFiles and StaticFilesConfig
* remove special casing of static files app from handlers/router
* remove outdated docs sections
* Add what's new section
* Rename tests for consistency
provinzkraut added a commit that referenced this pull request Jan 15, 2025
* Remove deprecated StaticFiles and StaticFilesConfig
* remove special casing of static files app from handlers/router
* remove outdated docs sections
* Add what's new section
* Rename tests for consistency
provinzkraut added a commit that referenced this pull request Jan 15, 2025
* Remove deprecated StaticFiles and StaticFilesConfig
* remove special casing of static files app from handlers/router
* remove outdated docs sections
* Add what's new section
* Rename tests for consistency
provinzkraut added a commit that referenced this pull request Jan 28, 2025
* Remove deprecated StaticFiles and StaticFilesConfig
* remove special casing of static files app from handlers/router
* remove outdated docs sections
* Add what's new section
* Rename tests for consistency
provinzkraut added a commit that referenced this pull request Feb 14, 2025
* Remove deprecated StaticFiles and StaticFilesConfig
* remove special casing of static files app from handlers/router
* remove outdated docs sections
* Add what's new section
* Rename tests for consistency
provinzkraut added a commit that referenced this pull request Feb 16, 2025
* Remove deprecated StaticFiles and StaticFilesConfig
* remove special casing of static files app from handlers/router
* remove outdated docs sections
* Add what's new section
* Rename tests for consistency
provinzkraut added a commit that referenced this pull request Feb 23, 2025
* Remove deprecated StaticFiles and StaticFilesConfig
* remove special casing of static files app from handlers/router
* remove outdated docs sections
* Add what's new section
* Rename tests for consistency
provinzkraut added a commit that referenced this pull request Feb 25, 2025
* Remove deprecated StaticFiles and StaticFilesConfig
* remove special casing of static files app from handlers/router
* remove outdated docs sections
* Add what's new section
* Rename tests for consistency
provinzkraut added a commit that referenced this pull request Feb 25, 2025
* Remove deprecated StaticFiles and StaticFilesConfig
* remove special casing of static files app from handlers/router
* remove outdated docs sections
* Add what's new section
* Rename tests for consistency
provinzkraut added a commit that referenced this pull request Feb 25, 2025
* Remove deprecated StaticFiles and StaticFilesConfig
* remove special casing of static files app from handlers/router
* remove outdated docs sections
* Add what's new section
* Rename tests for consistency
provinzkraut added a commit that referenced this pull request Feb 25, 2025
* Remove deprecated StaticFiles and StaticFilesConfig
* remove special casing of static files app from handlers/router
* remove outdated docs sections
* Add what's new section
* Rename tests for consistency
provinzkraut added a commit that referenced this pull request Feb 26, 2025
* Remove deprecated StaticFiles and StaticFilesConfig
* remove special casing of static files app from handlers/router
* remove outdated docs sections
* Add what's new section
* Rename tests for consistency
provinzkraut added a commit that referenced this pull request Feb 27, 2025
* Remove deprecated StaticFiles and StaticFilesConfig
* remove special casing of static files app from handlers/router
* remove outdated docs sections
* Add what's new section
* Rename tests for consistency
provinzkraut added a commit that referenced this pull request Feb 27, 2025
* Remove deprecated StaticFiles and StaticFilesConfig
* remove special casing of static files app from handlers/router
* remove outdated docs sections
* Add what's new section
* Rename tests for consistency
provinzkraut added a commit that referenced this pull request Feb 28, 2025
* Remove deprecated StaticFiles and StaticFilesConfig
* remove special casing of static files app from handlers/router
* remove outdated docs sections
* Add what's new section
* Rename tests for consistency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connection area/contrib This PR involves changes to the contrib (Deprecated) area/docs This PR involves changes to the documentation area/handlers This PR involves changes to the handlers area/middleware This PR involves changes to the middleware area/private-api This PR involves changes to the privatized API area/static-files area/template area/testing pr/internal size: large
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants