-
-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: deprecate litestar.contrib.sqlalchemy
#3755
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/dependencies
This PR involves changes to the dependencies
size: medium
type/feat
labels
Sep 22, 2024
cofin
force-pushed
the
deprecation-sqlalchemy
branch
from
September 22, 2024 00:00
e1a9bdf
to
f8bb774
Compare
github-actions
bot
added
the
area/docs
This PR involves changes to the documentation
label
Sep 22, 2024
github-actions
bot
added
area/plugins
This PR involves changes to the plugins
size: large
and removed
size: medium
labels
Sep 22, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3755 +/- ##
========================================
Coverage 98.35% 98.35%
========================================
Files 331 332 +1
Lines 15287 15460 +173
Branches 2447 2460 +13
========================================
+ Hits 15035 15206 +171
Misses 112 112
- Partials 140 142 +2 ☔ View full report in Codecov by Sentry. |
Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/3755 |
Alc-Alc
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/dependencies
This PR involves changes to the dependencies
area/docs
This PR involves changes to the documentation
area/plugins
This PR involves changes to the plugins
pr/internal
size: large
type/feat
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR deprecates the
litestar.contrib.sqlalchemy
module in favor oflitestar.plugins.sqlalchemy
Closes