-
-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: make sure that channels
use finally
in all examples
#3796
Conversation
This failure does not look related: https://github.com/litestar-org/litestar/actions/runs/11330520189/job/31508525457?pr=3796
|
@Alc-Alc can you please take a look? :) |
Quality Gate passedIssues Measures |
Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/3796 |
finally did 😅 thank you 🙂 |
Right now this code:
Is not really correct, because in case of an exception - it will not execute
await channels.unsubscribe(subscriber, ["foo"])
, which might be unexpected.There's a similar example above that use the correct form: