include index in Rank #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lithammer
reviewed
May 22, 2018
fuzzy/fuzzy.go
Outdated
| @@ -150,6 +156,9 @@ type Rank struct { | |||
|
|
|||
| // Distance is the Levenshtein distance between Source and Target. | |||
| Distance int | |||
|
|
|||
| // Location of Target in original list | |||
| Index int | |||
There was a problem hiding this comment.
I think the naming could be a potential cause for confusion. I expect many to assume Index here means the index in the filtered list, not the original one. OriginalIndex maybe...? Naming is hard :)
lithammer
approved these changes
May 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the string indices to the results returned from
RankFindandRankFindFold.This is especially useful when you want to sort non-string objects. You build an array containing the string representations of the objects, call
RankFindon the array, and then use the indices returned to look up the original objects.