Fix for crash when concurrent calls are made to find normalized fold #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlwelles
force-pushed
the
bugfix/concurrent-find-normalized-fold-panic
branch
from
d025b9e to
5ef9091
Compare
|
Nice find. And thanks for contributing a fix to boot! |
|
Tagged a v1.1.1 release with your fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, found it was possible to reliably cause panics when there are concurrent calls to
FindNormalizedFold()(and I thinkFindNormazlied(), too) that use the same slice as a target.Added a test to reproduce and fixed by changing the transformers from being package vars that are reused to being functions that return new instances on each use.
To reproduce the crash, you can run the test in the current release, or change
normalizeTransformer()andnormalizedFoldTransformer()in this PR to return an package var where the results from theTransform.Chaincalls they wrap have been assigned.