Engineering Issue Bot: Fix UIActivityViewController crash on iPad when sharing documents #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a NSGenericException crash that occurs when sharing documents from the chat viewer on iPad devices. The crash was caused by missing popover presentation controller configuration required for iPad. Changes: - Added popover anchor configuration for bar button item in onAction method - Added popover source view configuration for alert action share in openOptionsMenuFor method - Set appropriate source rect and arrow directions for centered presentation The fix ensures UIActivityViewController properly displays as a popover on iPad while maintaining full-screen presentation on iPhone devices. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
The Brand Messenger SDK was crashing on iPad when users attempted to share documents from the chat viewer. The crash was caused by UIPopoverPresentationController missing required anchor configuration on iPad devices.
Solution
Added popover presentation controller configuration in two locations:
Test Plan
References
🤖 Generated with Claude Code