Skip to content

Commit

Permalink
Reduce conditional_join nvbench configurations (rapidsai#16036)
Browse files Browse the repository at this point in the history
The current **JOIN_NVBENCH** uses three table sizes `1000, 100'000, 10'000'000` for all the **join** benchmarks.

But, **coditional** **joins** perform **X * Y** operations, and the large table size explodes the bench runtime. Hence we need to benchmark on smaller tables only.

This PR reduces **nvbench configurations** from **36** to **16** by using only two smaller table sizes `1000, 100'000` which lowers the overall benchmark runtime significantly.

Authors:
  - Srinivas Yadav (https://github.com/srinivasyadav18)

Approvers:
  - Yunsong Wang (https://github.com/PointKernel)
  - Karthikeyan (https://github.com/karthikeyann)

URL: rapidsai#16036
  • Loading branch information
srinivasyadav18 authored Jun 18, 2024
1 parent 7ff2764 commit 0bdf934
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions cpp/benchmarks/join/conditional_join.cu
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@

#include "join_common.hpp"

auto const CONDITIONAL_JOIN_SIZE_RANGE = std::vector<nvbench::int64_t>{1000, 100'000};

template <typename Key, bool Nullable>
void nvbench_conditional_inner_join(nvbench::state& state,
nvbench::type_list<Key, nvbench::enum_type<Nullable>>)
Expand Down Expand Up @@ -46,12 +48,12 @@ NVBENCH_BENCH_TYPES(nvbench_conditional_inner_join,
NVBENCH_TYPE_AXES(JOIN_KEY_TYPE_RANGE, JOIN_NULLABLE_RANGE))
.set_name("conditional_inner_join")
.set_type_axes_names({"Key", "Nullable"})
.add_int64_axis("left_size", JOIN_SIZE_RANGE)
.add_int64_axis("right_size", JOIN_SIZE_RANGE);
.add_int64_axis("left_size", CONDITIONAL_JOIN_SIZE_RANGE)
.add_int64_axis("right_size", CONDITIONAL_JOIN_SIZE_RANGE);

NVBENCH_BENCH_TYPES(nvbench_conditional_left_join,
NVBENCH_TYPE_AXES(JOIN_KEY_TYPE_RANGE, JOIN_NULLABLE_RANGE))
.set_name("conditional_left_join")
.set_type_axes_names({"Key", "Nullable"})
.add_int64_axis("left_size", JOIN_SIZE_RANGE)
.add_int64_axis("right_size", JOIN_SIZE_RANGE);
.add_int64_axis("left_size", CONDITIONAL_JOIN_SIZE_RANGE)
.add_int64_axis("right_size", CONDITIONAL_JOIN_SIZE_RANGE);

0 comments on commit 0bdf934

Please sign in to comment.