Fix unintended failure of if self._call_output
in future.py for objects with ambiguous truth values
#1397
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1396
As described in #1396, in
future.py
, the checkif self._call_output
fails (unintentionally) if the object assigned toself._call_output
has an ambiguous truth value, as is the case for pandas dataframes and numpy ndarrays.Changing this check to
if self._call_output is not None
fixes this unintended failure. The added test checks for this behavior with a custom object, to avoid taking a pandas and/or numpy dependency in the test environment.Developer's Certificate of Origin 1.1