Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unintended failure of if self._call_output in future.py for objects with ambiguous truth values #1397

Merged
merged 3 commits into from
Oct 1, 2024

Conversation

cisaacstern
Copy link
Contributor

Closes #1396

As described in #1396, in future.py, the check if self._call_output fails (unintentionally) if the object assigned to self._call_output has an ambiguous truth value, as is the case for pandas dataframes and numpy ndarrays.

Changing this check to if self._call_output is not None fixes this unintended failure. The added test checks for this behavior with a custom object, to avoid taking a pandas and/or numpy dependency in the test environment.

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@cisaacstern cisaacstern changed the title Is not none Fix unintended failure of if self._call_output in future.py for objects with ambiguous truth values Oct 1, 2024
@JosepSampe
Copy link
Member

Thanks for the contribution @cisaacstern !

@JosepSampe JosepSampe merged commit 944574f into lithops-cloud:master Oct 1, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In future.py, if self._call_output fails if truth value is ambiguous (e.g. np array, pd dataframe)
2 participants