chore(env): updated the env getter function & default jobCleanUpPolicy as retain #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: shubhamchaudhary <shubham@chaosnative.com>
|
Just added @kazukousen for review - as author of a recent refactor of the same! |
ispeakc0de
changed the title
ispeakc0de
force-pushed
the
env-updation
branch
2 times, most recently
from
07b4bd5 to
40c9045
Compare
kazukousen
previously approved these changes
May 19, 2021
rahulchheda
reviewed
May 19, 2021
| @@ -38,6 +38,20 @@ func (engineDetails *EngineDetails) SetEngineUID(clients ClientSets) error { | |||
|
|
|||
| //SetENV sets ENV values in experimentDetails struct. | |||
| func (expDetails *ExperimentDetails) SetENV(engineDetails EngineDetails, clients ClientSets) error { | |||
| // Setting envs from engine fields other than env | |||
| expDetails.setEnv("CHAOSENGINE", engineDetails.Name). | |||
There was a problem hiding this comment.
nit: Do we really need builder for setting ENV's. I would suggest a slice of ENV variables, as in v1.EnvVar, and then we don't have to do same function call again and again.
There was a problem hiding this comment.
- Added function to exclude all the envs who contains an empty value
- as the number of envs increases the slice size increases which can fail bch guidelines(4x lines)
| return "", errors.Errorf("unable to delete ChaosExperiment Job name: %v, in namespace: %v, error: %v", experiment.JobName, experiment.Namespace, err) | ||
| } | ||
| case v1alpha1.CleanUpPolicyRetain: | ||
| log.Infof("[skip]: skipping the job deletion as jobCleanUpPolicy is set to {%v}", expEngine.Spec.JobCleanUpPolicy) | ||
| default: |
There was a problem hiding this comment.
handling for string(expEngine.Spec.JobCleanUpPolicy) == "" is already in default, no need to create new variable for this.
There was a problem hiding this comment.
it is added to handle the cases, if someone added jobCleanUpPolicy to some wrong value other than delete or retain
Signed-off-by: shubhamchaudhary <shubham@chaosnative.com>
ksatchit
approved these changes
Jun 1, 2021
uditgaurav
approved these changes
Jun 1, 2021
ksatchit
pushed a commit
to ksatchit/chaos-runner
that referenced
this pull request
Jun 15, 2021
…y as retain (litmuschaos#144) * chore(env): improved the env getter function Signed-off-by: shubhamchaudhary <shubham@chaosnative.com> * marked default jobCleanupPolicy to retain Signed-off-by: shubhamchaudhary <shubham@chaosnative.com>
ksatchit
pushed a commit
that referenced
this pull request
Jun 15, 2021
* rm(vendor): removing the vendor directory from litmus-go (#147) Signed-off-by: shubhamchaudhary <shubham@chaosnative.com> * chore(env): updated the env getter function & default jobCleanUpPolicy as retain (#144) * chore(env): improved the env getter function Signed-off-by: shubhamchaudhary <shubham@chaosnative.com> * marked default jobCleanupPolicy to retain Signed-off-by: shubhamchaudhary <shubham@chaosnative.com> * chore(chaosresult): updating verdict and status in chaosengine and chaosresult (#148) Signed-off-by: shubhamchaudhary <shubham@chaosnative.com> * chore(vendors): updating the target details vendors (#149) Signed-off-by: shubhamchaudhary <shubham@chaosnative.com> * Fix: Print error for some error events (#150) Signed-off-by: udit <udit@chaosnative.com> Co-authored-by: Shubham Chaudhary <shubham.chaudhary@mayadata.io> Co-authored-by: Udit Gaurav <35391335+uditgaurav@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: shubhamchaudhary shubham@chaosnative.com
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Checklist:
documentationtagbreaking-changestagrequires-upgradetag