refactor(chaos_ns): Rename Engine_NAMESPACE to CHAOS_NAMESPACE #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: shubhamchaudhary <shubham.chaudhary@mayadata.io>
rahulchheda
changed the title
rahulchheda
approved these changes
Mar 30, 2020
ksatchit
approved these changes
Mar 30, 2020
rahulchheda
pushed a commit
to rahulchheda/chaos-runner
that referenced
this pull request
Mar 31, 2020
…schaos#57) Signed-off-by: shubhamchaudhary <shubham.chaudhary@mayadata.io>
rahulchheda
pushed a commit
to rahulchheda/chaos-runner
that referenced
this pull request
Mar 31, 2020
…schaos#57) Signed-off-by: shubhamchaudhary <shubham.chaudhary@mayadata.io> Signed-off-by: Rahul M Chheda <rahul.chheda@mayadata.io>
rahulchheda
pushed a commit
to rahulchheda/chaos-runner
that referenced
this pull request
Mar 31, 2020
…schaos#57) Signed-off-by: shubhamchaudhary <shubham.chaudhary@mayadata.io>
ksatchit
pushed a commit
that referenced
this pull request
Apr 1, 2020
* (fix) Added name of the runner Pod in ChaosEngine Events (#56) Signed-off-by: Rahul M Chheda <rahul.chheda@mayadata.io> * (feat) Added support for AdminMode (#45) * (feat) Added support for AdminMode - Replaced EngineDetails.AppNamespace to EngineDetails.EngineNamespace - Added logic to check for resources in chaosEngine namespace - Only job will be created in AppNamespace (experiment.Namespace) - Synced the experiment.Namespace = engineDetails.EngineNamespace, when AdminMode is true - Added OS ENV as ENGINE_NAMESPACE passed from operator, into engineDetails struct * Sycned experiment.Namespace and engineDetails.EngineNamespace Signed-off-by: Rahul M Chheda <rahul.chheda@mayadata.io> * refcator(chaos_ns): Rename Engine_NAMESPACE to CHAOS_NAMESPACE (#57) Signed-off-by: shubhamchaudhary <shubham.chaudhary@mayadata.io> Co-authored-by: Shubham Chaudhary <shubham.chaudhary@mayadata.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: shubhamchaudhary shubham.chaudhary@mayadata.io
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Checklist:
documentationtagbreaking-changestagrequires-upgradetag