feat: Add a locust-loandgen chaos fault #733
Open
+473
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwx4957
requested review from
ispeakc0de,
ksatchit and
uditgaurav
as code owners
Signed-off-by: DongYoung Kim <kwx4957@gmail.com>
Signed-off-by: DongYoung Kim <kwx4957@gmail.com>
Signed-off-by: DongYoung Kim <kwx4957@gmail.com>
Signed-off-by: DongYoung Kim <kwx4957@gmail.com>
Signed-off-by: DongYoung Kim <kwx4957@gmail.com>
6 tasks
ispeakc0de
reviewed
Jan 15, 2025
Comment on lines
73
to
82
| if chaosDetails.DefaultHealthCheck { | ||
| log.Info("[Status]: Verify that the AUT (Application Under Test) is running (pre-chaos)") | ||
| if err := status.AUTStatusCheck(clients, &chaosDetails); err != nil { | ||
| log.Errorf("Application status check failed, err: %v", err) | ||
| types.SetEngineEventAttributes(&eventsDetails, types.PreChaosCheck, "AUT: Not Running", "Warning", &chaosDetails) | ||
| events.GenerateEvents(&eventsDetails, clients, &chaosDetails, "ChaosEngine") | ||
| result.RecordAfterFailure(&chaosDetails, &resultDetails, err, clients, &eventsDetails) | ||
| return | ||
| } | ||
| } |
There was a problem hiding this comment.
we can remove the application status check (pre-chaos) as it is not applicable for this experiment?
ispeakc0de
reviewed
Jan 15, 2025
Comment on lines
118
to
127
| if chaosDetails.DefaultHealthCheck { | ||
| log.Info("[Status]: Verify that the AUT (Application Under Test) is running (post-chaos)") | ||
| if err := status.AUTStatusCheck(clients, &chaosDetails); err != nil { | ||
| log.Errorf("Application status check failed, err: %v", err) | ||
| types.SetEngineEventAttributes(&eventsDetails, types.PostChaosCheck, "AUT: Not Running", "Warning", &chaosDetails) | ||
| events.GenerateEvents(&eventsDetails, clients, &chaosDetails, "ChaosEngine") | ||
| result.RecordAfterFailure(&chaosDetails, &resultDetails, err, clients, &eventsDetails) | ||
| return | ||
| } | ||
| } |
|
hi @kwx4957 , could you resolve conflicts? |
Signed-off-by: DongYoung Kim <kwx4957@gmail.com>
|
@namkyu1999 yes, i resolved the conflict |
Signed-off-by: DongYoung Kim <kwx4957@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
i've implemented a new load test using locust based on proposal. you can add chaos hub
github: https://github.com/kwx4957/chaos-charts.git
branch: feat/locust
Result
dependency: chaos-charts
Reference:
#687
https://developer.harness.io/docs/chaos-engineering/use-harness-ce/chaos-faults/load/locust-loadgen/
Special notes for your reviewer:
Checklist:
breaking-changestagrequires-upgradetag