-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test/mocks: added mocks for test cases #4133
Merged
arkajyotiMukherjee
merged 10 commits into
litmuschaos:master
from
SohamRatnaparkhi:test/mocks
Sep 15, 2023
Merged
Test/mocks: added mocks for test cases #4133
arkajyotiMukherjee
merged 10 commits into
litmuschaos:master
from
SohamRatnaparkhi:test/mocks
Sep 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: SohamRatnaparkhi <soham.ratnaparkhi@gmail.com>
Signed-off-by: SohamRatnaparkhi <soham.ratnaparkhi@gmail.com>
Signed-off-by: SohamRatnaparkhi <soham.ratnaparkhi@gmail.com>
Signed-off-by: SohamRatnaparkhi <soham.ratnaparkhi@gmail.com>
Signed-off-by: SohamRatnaparkhi <soham.ratnaparkhi@gmail.com>
Signed-off-by: SohamRatnaparkhi <soham.ratnaparkhi@gmail.com>
namkyu1999
added
language/go
kind/unit-test
LFX-MENTORSHIP
Linux Foundation Mentor ship Issue
go
Pull requests that update Go code
labels
Aug 17, 2023
This was referenced Aug 17, 2023
namkyu1999
approved these changes
Aug 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
amityt
approved these changes
Sep 5, 2023
Saranya-jena
approved these changes
Sep 6, 2023
namkyu1999
added
READY TO MERGE
READY-FOR-REVIEW
and removed
READY-FOR-REVIEW
READY TO MERGE
labels
Sep 7, 2023
arkajyotiMukherjee
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
go
Pull requests that update Go code
kind/unit-test
language/go
LFX-MENTORSHIP
Linux Foundation Mentor ship Issue
READY-FOR-REVIEW
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR adds mocks for:
It also fixes incorrect mongo operator used in operators
Summarize your changes here to communicate with the maintainers and make sure to put the link of that issue
Types of changes
What types of changes does your code introduce to Litmus? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Dependency
Special notes for your reviewer:
This PR is related to LFX-Mentorship'23: Term2