Added changes required for dex setup for litmus 3.0.0-beta11 #4163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Saranya-jena <saranya.jena@harness.io>
Saranya-jena
requested review from
hrishavjha,
arkajyotiMukherjee and
SarthakJain26
Signed-off-by: Saranya-jena <saranya.jena@harness.io>
hrishavjha
approved these changes
Sep 12, 2023
| const searchParams = useSearchParams(); | ||
| const dexToken = searchParams.get('jwtToken'); | ||
| const dexProjectID = searchParams.get('projectID'); | ||
| const dexProjectRole = searchParams.get('projectRole'); |
There was a problem hiding this comment.
Suggested change
| const dexProjectRole = searchParams.get('projectRole'); | |
| const dexProjectRole = searchParams.get('projectRole') as PermissionGroup; |
| const dexProjectRole = searchParams.get('projectRole'); | ||
|
|
||
| React.useEffect(() => { | ||
| if (dexToken && dexProjectID) { |
There was a problem hiding this comment.
Suggested change
| if (dexToken && dexProjectID) { | |
| if (dexToken && dexProjectID && dexProjectRole) { |
SarthakJain26
requested changes
Sep 13, 2023
| Username: signedInUser.Username, | ||
| Name: signedInUser.Name, | ||
| Email: signedInUser.Email, | ||
| JoinedAt: time.Now().Unix(), |
There was a problem hiding this comment.
Please convert it to UnixMilli()
| state := "active" | ||
| newProject := &entities.Project{ | ||
| ID: uuid.Must(uuid.NewRandom()).String(), | ||
| Name: signedInUser.Username + "'s project", |
There was a problem hiding this comment.
Replace name with - instead of 's
| State: &state, | ||
| Audit: entities.Audit{ | ||
| IsRemoved: false, | ||
| CreatedAt: time.Now().Unix(), |
There was a problem hiding this comment.
Please use UnixMilli instead of Unix in all the places
Signed-off-by: Saranya-jena <saranya.jena@harness.io>
…ex-setup Signed-off-by: Saranya-jena <saranya.jena@harness.io>
Signed-off-by: Saranya-jena <saranya.jena@harness.io>
SarthakJain26
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Summarize your changes here to communicate with the maintainers and make sure to put the link of that issue
Types of changes
What types of changes does your code introduce to Litmus? Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Dependency
Special notes for your reviewer: