Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added loader in UserManagement modal. #4452

Merged
merged 8 commits into from
Mar 5, 2024

Conversation

aryan-bhokare
Copy link
Contributor

closes #4449

Proposed changes

Added a Loader in all the User Management modals based on the Loading of the query mutations.
Following includes the changes:

1. Account Details Change
2. Account Password Change
3. Create New Token 
4. Delete token
5. Create New User
6. Enable Disable User
7. ResetPassword

Types of changes

What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices applies)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the commit for DCO to be passed.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Special notes for your reviewer:

ScreenCast:

usermanagementloader.mp4

Signed-off-by: Aryan <aryan1bhokare@gmail.com>
Signed-off-by: Aryan Bhokare <92683836+aryan-bhokare@users.noreply.github.com>
@aryan-bhokare
Copy link
Contributor Author

Final change

buttonloader.mp4

Copy link
Member

@hrishavjha hrishavjha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the changes 🚀

@aryan-bhokare
Copy link
Contributor Author

LGTM, thanks for the changes 🚀

Thanks for the review!

@namkyu1999
Copy link
Member

Can you check build-pipeline / web-unit-tests (pull_request)?

Signed-off-by: Aryan Bhokare <92683836+aryan-bhokare@users.noreply.github.com>
@aryan-bhokare
Copy link
Contributor Author

Can you check build-pipeline / web-unit-tests (pull_request)?

fixed the error.

Copy link
Member

@namkyu1999 namkyu1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

aryan-bhokare and others added 2 commits February 21, 2024 08:49
Signed-off-by: Aryan Bhokare <92683836+aryan-bhokare@users.noreply.github.com>
@Saranya-jena Saranya-jena merged commit 52ab1d5 into litmuschaos:master Mar 5, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add loader in all the confirm buttons of Modals under User Management
5 participants