-
Notifications
You must be signed in to change notification settings - Fork 699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added loader in UserManagement modal. #4452
Added loader in UserManagement modal. #4452
Conversation
Signed-off-by: Aryan <aryan1bhokare@gmail.com>
chaoscenter/web/src/views/EnableDisableUser/EnableDisableUser.tsx
Outdated
Show resolved
Hide resolved
chaoscenter/web/src/views/AccountDetailsChange/AccountDetailsChange.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Aryan Bhokare <92683836+aryan-bhokare@users.noreply.github.com>
86712ed
to
3523d78
Compare
Final change buttonloader.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the changes 🚀
Thanks for the review! |
Can you check |
Signed-off-by: Aryan Bhokare <92683836+aryan-bhokare@users.noreply.github.com>
fixed the error. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Signed-off-by: Aryan Bhokare <92683836+aryan-bhokare@users.noreply.github.com>
closes #4449
Proposed changes
Added a Loader in all the User Management modals based on the Loading of the query mutations.
Following includes the changes:
Types of changes
What types of changes does your code introduce to Litmus? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Special notes for your reviewer:
ScreenCast:
usermanagementloader.mp4