Added fuzzers in utils and authorization(graphql) #4467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Saranya-jena <saranya.jena@harness.io>
SarthakJain26
requested changes
Feb 23, 2024
chaoscenter/graphql/server/pkg/authorization/tests/fuzz_test.go
Outdated
Show resolved
Hide resolved
| token := jwt.New(jwt.SigningMethodHS256) | ||
| claims := token.Claims.(jwt.MapClaims) | ||
| claims["username"] = username | ||
| claims["exp"] = time.Now().Add(-time.Hour).Unix() // Set expiration time to 1 hour ago |
There was a problem hiding this comment.
I see the time package being used in many functions, better to define the variable at a single place and pass it as function argument.
SarthakJain26
approved these changes
Feb 26, 2024
Signed-off-by: Saranya-jena <saranya.jena@harness.io>
Saranya-jena
force-pushed
the
fuzzer-test
branch
from
5b28ab9 to
8a0f124
Compare
Signed-off-by: Saranya-jena <saranya.jena@harness.io>
Signed-off-by: Saranya-jena <saranya.jena@harness.io>
namkyu1999
requested changes
Feb 28, 2024
chaoscenter/graphql/server/pkg/authorization/tests/fuzz_test.go
Outdated
Show resolved
Hide resolved
The ci build script is not correct and it's not running on the added TCs. Will share screenshots from my local runs |
Signed-off-by: Saranya-jena <saranya.jena@harness.io>
Signed-off-by: Saranya-jena <saranya.jena@harness.io>
|
@namkyu1999 I have made the directory changes, PTAL again! |
namkyu1999
approved these changes
Mar 12, 2024
| @@ -0,0 +1,81 @@ | |||
| package tests | |||
There was a problem hiding this comment.
Hey @Saranya-jena , this file is still in the /tests folder. Can you change this one? Other than that LGTM 🚀
There was a problem hiding this comment.
sorry missed it, added the changes
Signed-off-by: Saranya-jena <saranya.jena@harness.io>
namkyu1999
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Summarize your changes here to communicate with the maintainers and make sure to put the link of that issue
Types of changes
What types of changes does your code introduce to Litmus? Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Dependency
Special notes for your reviewer: