-
Notifications
You must be signed in to change notification settings - Fork 705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subscriber reconnect #4776
Merged
Saranya-jena
merged 5 commits into
litmuschaos:master
from
ledbruno:subscriber-reconnect
Aug 14, 2024
Merged
Subscriber reconnect #4776
Saranya-jena
merged 5 commits into
litmuschaos:master
from
ledbruno:subscriber-reconnect
Aug 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bruno Ledesma <led.bruno@gmail.com>
Signed-off-by: Bruno Ledesma <led.bruno@gmail.com>
amityt
reviewed
Jul 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
amityt
approved these changes
Jul 22, 2024
namkyu1999
approved these changes
Aug 6, 2024
Saranya-jena
approved these changes
Aug 14, 2024
kwx4957
pushed a commit
to kwx4957/litmus
that referenced
this pull request
Sep 1, 2024
* Force infra/subscriber disconnection when is already connected Signed-off-by: Bruno Ledesma <led.bruno@gmail.com> * Force infra/subscriber disconnection when is already connected Signed-off-by: Bruno Ledesma <led.bruno@gmail.com> --------- Signed-off-by: Bruno Ledesma <led.bruno@gmail.com>
andoriyaprashant
pushed a commit
to andoriyaprashant/litmus
that referenced
this pull request
Sep 7, 2024
* Force infra/subscriber disconnection when is already connected Signed-off-by: Bruno Ledesma <led.bruno@gmail.com> * Force infra/subscriber disconnection when is already connected Signed-off-by: Bruno Ledesma <led.bruno@gmail.com> --------- Signed-off-by: Bruno Ledesma <led.bruno@gmail.com> Signed-off-by: andoriyaprashant <prashantandoriya@gmail.com>
andoriyaprashant
pushed a commit
to andoriyaprashant/litmus
that referenced
this pull request
Sep 7, 2024
* Force infra/subscriber disconnection when is already connected Signed-off-by: Bruno Ledesma <led.bruno@gmail.com> * Force infra/subscriber disconnection when is already connected Signed-off-by: Bruno Ledesma <led.bruno@gmail.com> --------- Signed-off-by: Bruno Ledesma <led.bruno@gmail.com> Signed-off-by: andoriyaprashant <prashantandoriya@gmail.com>
sagnik3788
pushed a commit
to sagnik3788/litmus
that referenced
this pull request
Oct 5, 2024
* Force infra/subscriber disconnection when is already connected Signed-off-by: Bruno Ledesma <led.bruno@gmail.com> * Force infra/subscriber disconnection when is already connected Signed-off-by: Bruno Ledesma <led.bruno@gmail.com> --------- Signed-off-by: Bruno Ledesma <led.bruno@gmail.com> Signed-off-by: sagnik3788 <116512372+sagnik3788@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
On a scenario with multiple infrastructures connecting to a "main" chaoscenter/portal, we can have websocket disconnection cases. In those scenarios the subscriber exit with -1 code and pod is restarted, but fails to restablish connection because server responds ALREADY_CONNECTED.
We are proposing to changes
Subscriber
Portal/chaosCenter
Types of changes
What types of changes does your code introduce to Litmus? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.