Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename env to EC2_INSTANCE_TAG #4815

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Rename env to EC2_INSTANCE_TAG #4815

merged 1 commit into from
Aug 14, 2024

Conversation

jongwooo
Copy link
Contributor

@jongwooo jongwooo commented Aug 7, 2024

Proposed changes

Related issue #4807 (comment)

This PR fixes an issue where the ec2-stop-by-tag experiment fails to target the intended EC2 instance.

The ec2-stop-by-tag experiment encounters a TARGET_SELECTION_ERROR due to an incorrect retrieval of the EC2_INSTANCE_TAG environment variable.

Fault Summary:
TARGET_SELECTION_ERROR
{"errorCode":"TARGET_SELECTION_ERROR","phase":"PreChaos","reason":"failed to get the instance tag, invalid instance tag","target":"{EC2 Instance Tag: , Region: ap-northeast-2}"}

By correctly renaming the environment variable from INSTANCE_TAG to EC2_INSTANCE_TAG, we can accurately target the intended EC2 instance.

Types of changes

What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices applies)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the commit for DCO to be passed.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Special notes for your reviewer:

cc. @namkyu1999

Signed-off-by: Jongwoo Han <jongwooo.han@gmail.com>
@Jonsy13 Jonsy13 merged commit 87dc1c8 into litmuschaos:master Aug 14, 2024
17 checks passed
kwx4957 pushed a commit to kwx4957/litmus that referenced this pull request Sep 1, 2024
Signed-off-by: Jongwoo Han <jongwooo.han@gmail.com>
andoriyaprashant pushed a commit to andoriyaprashant/litmus that referenced this pull request Sep 7, 2024
Signed-off-by: Jongwoo Han <jongwooo.han@gmail.com>
Signed-off-by: andoriyaprashant <prashantandoriya@gmail.com>
andoriyaprashant pushed a commit to andoriyaprashant/litmus that referenced this pull request Sep 7, 2024
Signed-off-by: Jongwoo Han <jongwooo.han@gmail.com>
Signed-off-by: andoriyaprashant <prashantandoriya@gmail.com>
sagnik3788 pushed a commit to sagnik3788/litmus that referenced this pull request Oct 5, 2024
Signed-off-by: Jongwoo Han <jongwooo.han@gmail.com>
Signed-off-by: sagnik3788 <116512372+sagnik3788@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

4 participants