This repository has been archived by the owner on Apr 13, 2022. It is now read-only.
Add file traits #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add and correct basic support files for the vmm-sys-util crate including: - files generated by Cargo - license files - gitignore Signed-off-by: Jing Liu <jing2.liu@linux.intel.com>
The errno module wraps an interface to the error codes. The eventfd module is a wraper around the Linux eventfd. Use result::Result<EventFd, io::Error> instead of result::Result<EventFd, errno::Errno> as return type. The terminal module is for configuring pseudo-terminals in raw mode. The signal module is for registering signal handlers and for signalling threads. The ioctl module is factoring out common ioctl wrappers and macros. This is derived from crosvm code base e4ece32798ba436fbfa88466c571f46dab99e2be and firecracker code base 1fdde1997fc763601f8a88399bc426bd5d4097cd. Signed-off-by: Jing Liu <jing2.liu@linux.intel.com> --- Change Log Add license. Append prefix test_ for each test. Add verbose commit messages.
To use different init flag(e.g. SA_RESTART, SA_SIGINFO) for sigaction, add a parameter to register_signal_handler and a function to set this flag. Signed-off-by: Jing Liu <jing2.liu@linux.intel.com>
Wrapping the libc timerfd for the usage of setting timer, waiting expiring, disarm timer. This is derived from crosvm code base e4ece32798ba436fbfa88466c571f46dab99e2be. Signed-off-by: Jing Liu <jing2.liu@linux.intel.com> --- Change Log: Add license. Split the summary and description for method. Add link for structures and functions. Append prefix test_ for tests.
The poll module addis the Poller object for waiting on mutliple file descriptors at once. Add macro handle_eintr_errno! to check the epoll_wait return value. The syslog module is for logging, temporarily defining the SYS_getpid syscall value. This is derived from crosvm code base e4ece32798ba436fbfa88466c571f46dab99e2be. Signed-off-by: Jing Liu <jing2.liu@linux.intel.com> --- Change Log Append prefix test_ for tests.
Signed-off-by: Jing Liu <jing2.liu@linux.intel.com>
Several places are improved to suppress the clippy warnings. The changes of type casting in timerfd module are based on crosvm latest code base b1de6323ab8c96c52a60e0ff735e4bbb8a8464c9. Signed-off-by: Jing Liu <jing2.liu@linux.intel.com>
Copied verbatim from crosvm 107edb3e. Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
This will be needed for the write_zeroes and seek_hole implementations. Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
A dependency free alternative to the tempfile crate. Copied verbatim from crosvm 107edb3e. Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
This is needed for disk image format support like e.g. QCOW2. Copied verbatim from crosvm 107edb3e. Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
This is needed for disk image format support like e.g. QCOW2. Copied verbatim from crosvm 107edb3e. Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
|
@sameo I updated the patches removing MIT license. And solved the conflict for your PR. But it seems the website re-commit on your branch after conflict solving? |
liujing2
reviewed
May 7, 2019
| @@ -0,0 +1,37 @@ | |||
| // Copyright 2018 The Chromium OS Authors. All rights reserved. | |||
| // Use of this source code is governed by a BSD-style license that can be | |||
| // found in the LICENSE file. | |||
There was a problem hiding this comment.
// found in the LICENSE file.
LICENSE change to LICENSE-BSD-3-Clause?
liujing2
reviewed
May 7, 2019
| @@ -0,0 +1,102 @@ | |||
| // Copyright 2017 The Chromium OS Authors. All rights reserved. | |||
| // Use of this source code is governed by a BSD-style license that can be | |||
| // found in the LICENSE file. | |||
liujing2
reviewed
May 7, 2019
| // Use of this source code is governed by a BSD-style license that can be | ||
| // found in the LICENSE.BSD file. | ||
| // | ||
| // SPDX-License-Identifier: BSD-3-Clause |
There was a problem hiding this comment.
Do we need add an Intel Corp with Apache license?
liujing2
reviewed
May 7, 2019
| // Copyright 2018 The Chromium OS Authors. All rights reserved. | ||
| // Use of this source code is governed by a BSD-style license that can be | ||
| // found in the LICENSE file. | ||
|
|
|
@liujing2 All fixed now. I also replaced the travic CI with a buildkite one. Please let me know if it needs further work. |
|
Closing that one, replacing it with #2 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed for supporting disk image formats like e.g. QCOW.