-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: Hardcoded separator "_" doesn't work for 10X H5 format, in scATAC_genescore.py #1
Comments
Hi Tao, the peaks generated by MAESTRO will be separated using "_" and can run smoothly with the scATAC_genescore code. In the latest version of MAESTRO, we implemented the gene score function in R, and replace the separator of all the input peaks to standard "_", which will be consistent with the python code thus solve the problem. Thanks for reporting this bug! Let me know if you still facing problems. |
crazyhottommy
pushed a commit
that referenced
this issue
Jan 15, 2021
Create maestro-package-conda.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The following line for calculating RP scores assumes that peaks are named as "chr_start_end" in peak matrix.
MAESTRO/MAESTRO/scATAC_genescore.py
Line 97 in ffdfffe
However, the standard output "filtered_peak_bc_matrix.h5" from 10X cellranger-atac may use chr:start-end", according to
https://support.10xgenomics.com/single-cell-atac/software/pipelines/latest/advanced/h5_matrices
Suggest replacing the separator in the peak column to a standard character (either "_" or "-") in MAESTRO R script after loading the H5 file.
The text was updated successfully, but these errors were encountered: