Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dark mode + a bunch of fixes/tweaks #47

Merged
merged 22 commits into from
Apr 28, 2024
Merged

Dark mode + a bunch of fixes/tweaks #47

merged 22 commits into from
Apr 28, 2024

Conversation

DiegoAndresCortes
Copy link

No description provided.

@DiegoAndresCortes DiegoAndresCortes marked this pull request as draft March 9, 2024 22:40
@DiegoAndresCortes DiegoAndresCortes force-pushed the diego-theme branch 3 times, most recently from 4579f49 to 2bdc5ba Compare March 11, 2024 00:09
@DiegoAndresCortes
Copy link
Author

I've included a rework of the dark mode and improved the variants too.
In my next commit I will send update for the actual dark mode of the theme.

@DiegoAndresCortes
Copy link
Author

I'm almost done with the dark file, will finish up soon.
Some colors will be guess work because certain features are now broken or were broken before so can't test everything yet.

@DiegoAndresCortes
Copy link
Author

I added a wip on 65937b5
Will update the commit in the next day or so with the missing colors

@DiegoAndresCortes
Copy link
Author

I could remove more saturation on dark mode so it's less blue, but we should probably ask more people about that later on...

@DiegoAndresCortes
fixes
75f1664 
Signed-off-by: Diego Andrés <diegoandres_cortes@outlook.com>
@DiegoAndresCortes
remove padding and margins from variables
87e5956 
Signed-off-by: Diego Andrés <diegoandres_cortes@outlook.com>
@DiegoAndresCortes
decouple postbit css
17af5e5 
Signed-off-by: Diego Andrés <diegoandres_cortes@outlook.com>
@DiegoAndresCortes
expand and select fix
c5d7cfd 
Signed-off-by: Diego Andrés <diegoandres_cortes@outlook.com>
@DiegoAndresCortes
use same styles/markup for item lists
c138ef7 
Signed-off-by: Diego Andrés <diegoandres_cortes@outlook.com>
@DiegoAndresCortes
revamp variants and dark mode
d0f6f3b 
Signed-off-by: Diego Andrés <diegoandres_cortes@outlook.com>
@DiegoAndresCortes
additional fixes
60b4105 
Signed-off-by: Diego Andrés <diegoandres_cortes@outlook.com>
@DiegoAndresCortes
use correct method for time
9f1348f 
Signed-off-by: Diego Andrés <diegoandres_cortes@outlook.com>
@DiegoAndresCortes
variant and color mode fixes
59bc843 
Signed-off-by: Diego Andrés <diegoandres_cortes@outlook.com>
@DiegoAndresCortes
style and color fixes
5147632 
Signed-off-by: Diego Andrés <diegoandres_cortes@outlook.com>
@DiegoAndresCortes
update user option for variant or color mode when switching
ec8860e 
Signed-off-by: Diego Andrés <diegoandres_cortes@outlook.com>
@DiegoAndresCortes
fix search layout
095a263 
Signed-off-by: Diego Andrés <diegoandres_cortes@outlook.com>
@DiegoAndresCortes
dark mode colors
ff22b50 
Signed-off-by: Diego Andrés <diegoandres_cortes@outlook.com>
@DiegoAndresCortes
calendar and date fixes
086659e 
Signed-off-by: Diego Andrés <diegoandres_cortes@outlook.com>
@DiegoAndresCortes
Copy link
Author

I was slacking for vacation.
I'll finish off the sceditor variables before the weekend and mark it ready.

@live627
Copy link
Owner

live627 commented Apr 2, 2024 via email

@DiegoAndresCortes
Copy link
Author

What about the buttonlist, make the page index a block element?
For style we can do transparent for active background and give it orange text color so they are less blocky and smaller.

@DiegoAndresCortes
Copy link
Author

Should we replace the editor icons with fontawesome? So we can color them? Otherwise we would have to leave the group background the same for dark mode.

@DiegoAndresCortes
sceditor css vars
7112d9f 
Signed-off-by: Diego Andrés <diegoandres_cortes@outlook.com>
@DiegoAndresCortes
timepicker css
8d0471c 
Signed-off-by: Diego Andrés <diegoandres_cortes@outlook.com>
@DiegoAndresCortes
rtl more cleanup
f5ceb97 
Signed-off-by: Diego Andrés <diegoandres_cortes@outlook.com>
@DiegoAndresCortes DiegoAndresCortes marked this pull request as ready for review April 3, 2024 03:14
@DiegoAndresCortes
random news, newsfader fix, slogan and user_panel alignment
598431b 
Signed-off-by: Diego Andrés <diegoandres_cortes@outlook.com>
@DiegoAndresCortes DiegoAndresCortes changed the title Various changes wip Dark mode + a bunch of fixes/tweaks Apr 14, 2024
@DiegoAndresCortes DiegoAndresCortes force-pushed the diego-theme branch 2 times, most recently from 899e9be to 1ac80ed Compare April 15, 2024 00:16
@DiegoAndresCortes
tweak info_center markup and css
1517894 
Signed-off-by: Diego Andrés <diegoandres_cortes@outlook.com>
@DiegoAndresCortes
genericmenu fixes
d11f6d5 
Signed-off-by: Diego Andrés <diegoandres_cortes@outlook.com>
@DiegoAndresCortes
word-break for signatures
5d5d47f 
Signed-off-by: Diego Andrés <diegoandres_cortes@outlook.com>
@DiegoAndresCortes
fix buttonlist dropdown and remove bloat
8d3f60a 
Signed-off-by: Diego Andrés <diegoandres_cortes@outlook.com>
@DiegoAndresCortes
Copy link
Author

@live627 can you merge/rebase the branch (whichever order you want).
There are too many changes and still need to test the sceditor styling.

Do you know if the topics are loading excruciatingly slow on the main branch too?

@live627 live627 merged commit 1ef8fe4 into live627:theme Apr 28, 2024
6 of 7 checks passed
@DiegoAndresCortes DiegoAndresCortes deleted the diego-theme branch April 28, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@live627 live627 live627 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DiegoAndresCortes @live627