Do not override RELEASE_DISTRIBUTION in release to allow rpc #2922
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonatanklosko
commented
Jan 30, 2025
jonatanklosko
commented
Jan 30, 2025
|
Uffizzi Preview |
josevalim
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We start distribution programmatically as part of boot, so we set
RELEASE_DISTRIBUTION=none. However, when debugging inside a release we may want to connect via a remote shell. This should work if we run it asRELEASE_DISTRIBUTION=name /bin/app/livebook remote, however currently we always override it withRELEASE_DISTRIBUTION=none. This PR changes it, such that we check ifRELEASE_DISTRIBUTIONis defined.