Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Switch] Lock icon and cursor not-allowed for disabled state #344

Closed
sgraczyk opened this issue Jul 19, 2022 · 1 comment · Fixed by #353
Closed

[Switch] Lock icon and cursor not-allowed for disabled state #344

sgraczyk opened this issue Jul 19, 2022 · 1 comment · Fixed by #353
Assignees
@sgraczyk
Labels
feature New feature or request

Comments

@sgraczyk
Copy link

Description

Switch component should have a lock icon and

cursor: not-allowed;

in case of a disabled state.

Design

Figma - Locked Switch

image
@sgraczyk sgraczyk added the feature New feature or request label Jul 19, 2022
@sgraczyk sgraczyk added this to the v1.0.0 milestone Jul 19, 2022
@sgraczyk sgraczyk moved this to Selected for Development in LiveChat Design System Jul 19, 2022
@sgraczyk sgraczyk self-assigned this Jul 22, 2022
sgraczyk pushed a commit that referenced this issue Jul 22, 2022
#344 Handle Switch disabled state visually.
b1ba318
@sgraczyk sgraczyk mentioned this issue Jul 22, 2022
Merged
@sgraczyk sgraczyk moved this from Selected for Development to In Progress in LiveChat Design System Jul 22, 2022
@sgraczyk sgraczyk linked a pull request Jul 22, 2022 that will close this issue
#344 Handle Switch disabled state visually #353
Merged
sgraczyk pushed a commit that referenced this issue Jul 26, 2022
#344 Handle Switch disabled state visually (#353)
6a0c3ca 
* Lock icon added for the disabled state,
* Applied proper color tokens for `hover`, `enabled`, and `disabled` cases,
* Changed naming convention as `enabled/disabled` was easy to be confused with `checked (on)/unchecked (off)`,
* Added multiple stories representing the changes,
* Used `--color-action-default-rgb` for `box-shadow`
* Added `StoryDescriptor` component for wrapping components that require additional description
@sgraczyk sgraczyk moved this from In Progress to Done in LiveChat Design System Jul 26, 2022
@sgraczyk
Copy link
Author

Released in v1.0.0-alpha.17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgraczyk sgraczyk

Labels
feature New feature or request
Projects
LiveChat Design System
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#344 Handle Switch disabled state visually livechat/design-system
1 participant
@sgraczyk