Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Button] - Plain : update Active and Focus states #861

Closed
vladko-uxds opened this issue Oct 24, 2023 · 0 comments · Fixed by #870
Closed

[Button] - Plain : update Active and Focus states #861

vladko-uxds opened this issue Oct 24, 2023 · 0 comments · Fixed by #870
Assignees
@VadymBezpalko
Labels
design UI/UX oriented issue
Milestone
v1.0

Comments

@vladko-uxds
Copy link

vladko-uxds commented Oct 24, 2023 •
edited
Loading

Actual result:
On mouse click visible "focus ring" + background color --surface-primary-active

Expected:
On mouse click "Active state" surface background changed to: --surface-primary-active and no "focus ring"
On focus with a keyboard: --surface-primary-hover + border/box-shadow "focus ring"

Focus ring token already exists in DS: --shadow-focus

Image
@vladko-uxds vladko-uxds converted this from a draft issue Oct 24, 2023
@vladko-uxds vladko-uxds added this to the v1.0 milestone Oct 24, 2023
@vladko-uxds vladko-uxds added the design UI/UX oriented issue label Oct 24, 2023
@vladko-uxds vladko-uxds moved this from Backlog to Selected for Development in LiveChat Design System Oct 27, 2023
@VadymBezpalko VadymBezpalko self-assigned this Oct 27, 2023
@VadymBezpalko VadymBezpalko moved this from Selected for Development to In Progress in LiveChat Design System Oct 30, 2023
@VadymBezpalko VadymBezpalko mentioned this issue Oct 30, 2023
Merged
4 tasks
@VadymBezpalko VadymBezpalko moved this from In Progress to In Review in LiveChat Design System Oct 30, 2023
VadymBezpalko added a commit that referenced this issue Oct 31, 2023
@VadymBezpalko
fix(Button): #861 - update active and focus states (#870)
f6ac9c2
@github-project-automation github-project-automation bot moved this from In Review to Done in LiveChat Design System Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VadymBezpalko VadymBezpalko

Labels
design UI/UX oriented issue
Projects
LiveChat Design System
Archived in project
Milestone
v1.0
Development

Successfully merging a pull request may close this issue.

fix(Button): #861 - update active and focus states livechat/design-system
2 participants
@VadymBezpalko @vladko-uxds