Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(AutoComplete): fix autocomplete behavior in forms by preventing submissions on Enter keypress #1350

Merged
merged 3 commits into from
Sep 17, 2024
Merged

fix(AutoComplete): fix autocomplete behavior in forms by preventing submissions on Enter keypress #1350

merged 3 commits into from
Sep 17, 2024

Conversation

ashbork
Copy link
Contributor

@ashbork ashbork commented Sep 16, 2024 •
edited
Loading

Description

Prevents Enter key event bubbling while using the AutoComplete picker

Storybook

https://fix-autocomplete-prevent-default--613a8e945a5665003a05113b.chromatic.com

Checklist

Obligatory:

  • Self review (use this as your final check for proposed changes before requesting the review)
  • Add correct label
  • Assign pull request with the correct issue

@ashbork ashbork merged commit a2c12ca into main Sep 17, 2024
5 checks passed
@ashbork ashbork deleted the fix/autocomplete-prevent-default branch September 17, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VadymBezpalko VadymBezpalko VadymBezpalko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ashbork @VadymBezpalko