Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Accordion): change label height based on child component #1359

Merged
merged 2 commits into from
Sep 20, 2024
Merged

feat(Accordion): change label height based on child component #1359

merged 2 commits into from
Sep 20, 2024

Conversation

kubaczerwinski77
Copy link
Contributor

@kubaczerwinski77 kubaczerwinski77 commented Sep 19, 2024 •
edited
Loading

Resolves: #{issue-number}

Description

Define the label height based on child component

Storybook

https://feature-1358--613a8e945a5665003a05113b.chromatic.com

Checklist

Obligatory:

  • Self review (use this as your final check for proposed changes before requesting the review)
  • Add correct label
  • Assign pull request with the correct issue

@kubaczerwinski77 kubaczerwinski77 linked an issue Sep 19, 2024 that may be closed by this pull request
[Accordion] - adjust label height based on content #1358
Closed
@kubaczerwinski77 kubaczerwinski77 added the feature New feature or request label Sep 19, 2024
@marcinsawicki marcinsawicki added this to the Cycle #10 milestone Sep 19, 2024
@VadymBezpalko VadymBezpalko merged commit aa50666 into main Sep 20, 2024
5 checks passed
@VadymBezpalko VadymBezpalko deleted the feature/1358 branch September 20, 2024 07:25
VadymBezpalko pushed a commit that referenced this pull request Sep 20, 2024
@kubaczerwinski77 @VadymBezpalko
feat(Accordion): change label height based on child component (#1359)
ab0bdf5 
(cherry picked from commit aa50666)
VadymBezpalko added a commit that referenced this pull request Sep 20, 2024
@VadymBezpalko @kubaczerwinski77
feat(Accordion): change label height based on child component (#1359) (…
dc5875e 
…#1360)

Co-authored-by: Jakub Czerwiński <86623851+kubaczerwinski77@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mreszke mreszke mreszke approved these changes

@marcinsawicki marcinsawicki marcinsawicki approved these changes

@VadymBezpalko VadymBezpalko VadymBezpalko approved these changes

Assignees
No one assigned
Labels
feature New feature or request
Projects
LiveChat Design System
Archived in project
Milestone
Cycle #10
Development

Successfully merging this pull request may close these issues.

[Accordion] - adjust label height based on content
4 participants
@kubaczerwinski77 @VadymBezpalko @marcinsawicki @mreszke