-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(InviteAgents): new component #1363
Conversation
IMO it would be better to remove
|
/** | ||
* Custom style for the avatar | ||
*/ | ||
style?: React.CSSProperties; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this should be a part of ComponentCoreProps
? 🤔
]; | ||
|
||
const onAddTeammateClick = () => { | ||
console.log('Add Teammate Clicked'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we shouldn't put the console.log
in the docs. Simple () => {}
is enough imo 🤔
> | ||
{hasOnlyUnavailableAgents ? ( | ||
<Interactive | ||
header="No one's available to assist customers" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO a request to change copy here or elsewhere will appear sooner rather than later. 😅 Shouldn't we leave this open for custom string? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are at least a few different places with this copy, so if we want to move it to props then other places should be covered too, so I'd leave it like that for now
avatar: string; | ||
} | ||
|
||
export interface InviteAgentsProps { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extend ComponentCoreProps
? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left some comments
@mreszke The problem is that we have a 'Set up ChatBot' CTA in a dedicated tooltip, so it needs to be passed either way. |
Description
New component: FIGMA
Storybook
https://feature-invite-agents--613a8e945a5665003a05113b.chromatic.com
Checklist
Obligatory: